mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
[BREAKING]: remove deprecated routePath before GA (#1505)
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
parent
4474d87ed2
commit
c93ee4ea6d
@ -101,7 +101,6 @@ export default class ExampleRendererExtension extends LensRendererExtension {
|
|||||||
globalPages = [
|
globalPages = [
|
||||||
{
|
{
|
||||||
id: "example",
|
id: "example",
|
||||||
routePath: "/example",
|
|
||||||
components: {
|
components: {
|
||||||
Page: ExamplePage,
|
Page: ExamplePage,
|
||||||
}
|
}
|
||||||
@ -156,7 +155,7 @@ import { ExampleIcon, ExamplePage } from "./src/page"
|
|||||||
export default class ExampleExtension extends LensRendererExtension {
|
export default class ExampleExtension extends LensRendererExtension {
|
||||||
clusterPages = [
|
clusterPages = [
|
||||||
{
|
{
|
||||||
routePath: "/extension-example", // optional
|
id: "extension-example", // optional
|
||||||
exact: true, // optional
|
exact: true, // optional
|
||||||
components: {
|
components: {
|
||||||
Page: () => <ExamplePage extension={this}/>,
|
Page: () => <ExamplePage extension={this}/>,
|
||||||
|
|||||||
@ -85,7 +85,7 @@ import React from "react"
|
|||||||
export default class ExampleExtension extends LensRendererExtension {
|
export default class ExampleExtension extends LensRendererExtension {
|
||||||
clusterPages = [
|
clusterPages = [
|
||||||
{
|
{
|
||||||
routePath: "/extension-example",
|
id: "extension-example",
|
||||||
components: {
|
components: {
|
||||||
Page: () => <ExamplePage extension={this}/>,
|
Page: () => <ExamplePage extension={this}/>,
|
||||||
}
|
}
|
||||||
@ -94,4 +94,4 @@ export default class ExampleExtension extends LensRendererExtension {
|
|||||||
}
|
}
|
||||||
```
|
```
|
||||||
|
|
||||||
The Hello World sample extension uses the `Cluster Page` capability, which is just one of the Lens extension API's capabilities. The [Common Capabilities](../capabilities/common-capabilities.md) page will help you home in on the right capabilities to use with your own extensions.
|
The Hello World sample extension uses the `Cluster Page` capability, which is just one of the Lens extension API's capabilities. The [Common Capabilities](../capabilities/common-capabilities.md) page will help you home in on the right capabilities to use with your own extensions.
|
||||||
|
|||||||
@ -1,5 +1,5 @@
|
|||||||
{
|
{
|
||||||
"name": "extension-example",
|
"name": "example-extension",
|
||||||
"version": "1.0.0",
|
"version": "1.0.0",
|
||||||
"description": "Example extension",
|
"description": "Example extension",
|
||||||
"main": "dist/main.js",
|
"main": "dist/main.js",
|
||||||
|
|||||||
@ -6,7 +6,6 @@ export default class ExampleExtension extends LensRendererExtension {
|
|||||||
clusterPages = [
|
clusterPages = [
|
||||||
{
|
{
|
||||||
id: "example",
|
id: "example",
|
||||||
routePath: "/extension-example",
|
|
||||||
title: "Example Extension",
|
title: "Example Extension",
|
||||||
components: {
|
components: {
|
||||||
Page: () => <ExamplePage extension={this}/>,
|
Page: () => <ExamplePage extension={this}/>,
|
||||||
|
|||||||
@ -306,7 +306,6 @@ export class ExtensionDiscovery {
|
|||||||
}
|
}
|
||||||
|
|
||||||
const extension = await this.loadExtensionFromPath(absPath);
|
const extension = await this.loadExtensionFromPath(absPath);
|
||||||
|
|
||||||
if (extension) {
|
if (extension) {
|
||||||
extensions.push(extension);
|
extensions.push(extension);
|
||||||
}
|
}
|
||||||
@ -328,4 +327,4 @@ export class ExtensionDiscovery {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
export const extensionDiscovery = new ExtensionDiscovery();
|
export const extensionDiscovery = new ExtensionDiscovery();
|
||||||
|
|||||||
@ -16,11 +16,6 @@ export interface PageRegistration {
|
|||||||
* When not provided, first registered page without "id" would be used for page-menus without target.pageId for same extension
|
* When not provided, first registered page without "id" would be used for page-menus without target.pageId for same extension
|
||||||
*/
|
*/
|
||||||
id?: string;
|
id?: string;
|
||||||
/**
|
|
||||||
* Alias to page ID which assume to be used as path with possible :param placeholders
|
|
||||||
* @deprecated
|
|
||||||
*/
|
|
||||||
routePath?: string;
|
|
||||||
/**
|
/**
|
||||||
* Strict route matching to provided page-id, read also: https://reactrouter.com/web/api/NavLink/exact-bool
|
* Strict route matching to provided page-id, read also: https://reactrouter.com/web/api/NavLink/exact-bool
|
||||||
* In case when more than one page registered at same extension "pageId" is required to identify different pages,
|
* In case when more than one page registered at same extension "pageId" is required to identify different pages,
|
||||||
@ -65,7 +60,7 @@ export class PageRegistry extends BaseRegistry<RegisteredPage> {
|
|||||||
registeredPages = itemArray.map(page => ({
|
registeredPages = itemArray.map(page => ({
|
||||||
...page,
|
...page,
|
||||||
extensionId: ext.name,
|
extensionId: ext.name,
|
||||||
routePath: getExtensionPageUrl({ extensionId: ext.name, pageId: page.id ?? page.routePath }),
|
routePath: getExtensionPageUrl({ extensionId: ext.name, pageId: page.id }),
|
||||||
}));
|
}));
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
logger.error(`[EXTENSION]: page-registration failed`, {
|
logger.error(`[EXTENSION]: page-registration failed`, {
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user