hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

[BREAKING]: remove deprecated routePath before GA (#1505)

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2020-11-25 05:03:57 -05:00 committed by GitHub
parent 4474d87ed2
commit c93ee4ea6d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/extensions/capabilities/common-capabilities.md
View File

@ -101,7 +101,6 @@ export default class ExampleRendererExtension extends LensRendererExtension {
globalPages = [
{
id: "example",
routePath: "/example",
components: {
Page: ExamplePage,
}
@ -156,7 +155,7 @@ import { ExampleIcon, ExamplePage } from "./src/page"
export default class ExampleExtension extends LensRendererExtension {
clusterPages = [
{
routePath: "/extension-example", // optional
id: "extension-example", // optional
exact: true, // optional
components: {
Page: () => <ExamplePage extension={this}/>,

2
docs/extensions/get-started/anatomy.md
View File

@ -85,7 +85,7 @@ import React from "react"
export default class ExampleExtension extends LensRendererExtension {
clusterPages = [
{
routePath: "/extension-example",
id: "extension-example",
components: {
Page: () => <ExamplePage extension={this}/>,
}

2
extensions/example-extension/package.json
View File

@ -1,5 +1,5 @@
{
"name": "extension-example",
"name": "example-extension",
"version": "1.0.0",
"description": "Example extension",
"main": "dist/main.js",

1
extensions/example-extension/renderer.tsx
View File

@ -6,7 +6,6 @@ export default class ExampleExtension extends LensRendererExtension {
clusterPages = [
{
id: "example",
routePath: "/extension-example",
title: "Example Extension",
components: {
Page: () => <ExamplePage extension={this}/>,

1
src/extensions/extension-discovery.ts
View File

@ -306,7 +306,6 @@ export class ExtensionDiscovery {
}
const extension = await this.loadExtensionFromPath(absPath);
if (extension) {
extensions.push(extension);
}

7
src/extensions/registries/page-registry.ts
View File

@ -16,11 +16,6 @@ export interface PageRegistration {
* When not provided, first registered page without "id" would be used for page-menus without target.pageId for same extension
*/
id?: string;
/**
* Alias to page ID which assume to be used as path with possible :param placeholders
* @deprecated
*/
routePath?: string;
/**
* Strict route matching to provided page-id, read also: https://reactrouter.com/web/api/NavLink/exact-bool
* In case when more than one page registered at same extension "pageId" is required to identify different pages,
@ -65,7 +60,7 @@ export class PageRegistry extends BaseRegistry<RegisteredPage> {
registeredPages = itemArray.map(page => ({
...page,
extensionId: ext.name,
routePath: getExtensionPageUrl({ extensionId: ext.name, pageId: page.id ?? page.routePath }),
routePath: getExtensionPageUrl({ extensionId: ext.name, pageId: page.id }),
}));
} catch (err) {
logger.error(`[EXTENSION]: page-registration failed`, {