1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

Use lefecycleEnum.singleton and bit of cleaning up

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2022-06-08 11:36:32 +03:00
parent 4ac9ae21cb
commit d54fb3e12c

View File

@ -26,16 +26,17 @@ const extensionsPreferenceItemsInjectable = getInjectable({
const extensions = di.inject(rendererExtensionsInjectable); const extensions = di.inject(rendererExtensionsInjectable);
const { extensionId, tabId } = pathParams.get(); const { extensionId, tabId } = pathParams.get();
const extension = extensions.get().find((extension) => extension.sanitizedExtensionId === extensionId); const extension = extensions.get().find((extension) => extension.sanitizedExtensionId === extensionId);
if (!extension) {
return computed(() => []);
}
const preferences = extension.appPreferences.map(preference => ({ const preferences = extension.appPreferences.map(preference => ({
id: preference.id, id: preference.id || preference.title,
...preference, ...preference,
})); }));
return computed(() => { return computed(() => {
if (!extension) {
return [];
}
if (tabId) { if (tabId) {
return preferences.filter(preference => preference.showInPreferencesTab == tabId); return preferences.filter(preference => preference.showInPreferencesTab == tabId);
} }
@ -43,7 +44,7 @@ const extensionsPreferenceItemsInjectable = getInjectable({
return preferences.filter(preference => !preference.showInPreferencesTab); return preferences.filter(preference => !preference.showInPreferencesTab);
}); });
}, },
lifecycle: lifecycleEnum.transient, lifecycle: lifecycleEnum.singleton,
}); });
export default extensionsPreferenceItemsInjectable; export default extensionsPreferenceItemsInjectable;