hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Rename injectable file to be better name

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2022-12-06 15:11:57 -05:00
parent a8856861f1
commit dbae65b488
4 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/common/cluster/cluster.ts
View File

@ -19,7 +19,7 @@ import { ClusterMetadataKey, initialNodeShellImage, ClusterStatus, clusterModelI
import { disposer, isDefined, isRequestError, toJS } from "../utils";
import type { Response } from "request";
import { clusterListNamespaceForbiddenChannel } from "../ipc/cluster";
import type { CanI } from "./authorization-review.injectable";
import type { CreateAuthorizationReview } from "./create-authorization-review.injectable";
import type { ListNamespaces } from "./list-namespaces.injectable";
import assert from "assert";
import type { Logger } from "../logger";
@ -35,7 +35,7 @@ export interface ClusterDependencies {
createKubeconfigManager: (cluster: Cluster) => KubeconfigManager;
createContextHandler: (cluster: Cluster) => ClusterContextHandler;
createKubectl: (clusterVersion: string) => Kubectl;
createAuthorizationReview: (config: KubeConfig) => CanI;
createAuthorizationReview: CreateAuthorizationReview;
requestApiResources: RequestApiResources;
requestNamespaceListPermissionsFor: RequestNamespaceListPermissionsFor;
createListNamespaces: (config: KubeConfig) => ListNamespaces;
@ -475,6 +475,7 @@ export class Cluster implements ClusterModel {
resource: "*",
verb: "create",
});
console.log("finished this.isAdmin");
this.isGlobalWatchEnabled = await canI({
verb: "watch",
resource: "*",

10
src/common/cluster/authorization-review.injectable.ts → src/common/cluster/create-authorization-review.injectable.ts
View File

@ -19,11 +19,11 @@ export type CanI = (resourceAttributes: V1ResourceAttributes) => Promise<boolean
/**
* @param proxyConfig This config's `currentContext` field must be set, and will be used as the target cluster
*/
export type AuthorizationReview = (proxyConfig: KubeConfig) => CanI;
export type CreateAuthorizationReview = (proxyConfig: KubeConfig) => CanI;
const authorizationReviewInjectable = getInjectable({
id: "authorization-review",
instantiate: (di): AuthorizationReview => {
const createAuthorizationReviewInjectable = getInjectable({
id: "create-authorization-review",
instantiate: (di): CreateAuthorizationReview => {
const logger = di.inject(loggerInjectable);
const makeApiClient = di.inject(makeApiClientInjectable);
@ -49,4 +49,4 @@ const authorizationReviewInjectable = getInjectable({
},
});
export default authorizationReviewInjectable;
export default createAuthorizationReviewInjectable;

4
src/main/__test__/cluster.test.ts
View File

@ -9,8 +9,8 @@ import { Kubectl } from "../kubectl/kubectl";
import { getDiForUnitTesting } from "../getDiForUnitTesting";
import type { CreateCluster } from "../../common/cluster/create-cluster-injection-token";
import { createClusterInjectionToken } from "../../common/cluster/create-cluster-injection-token";
import authorizationReviewInjectable from "../../common/cluster/authorization-review.injectable";
import requestNamespaceListPermissionsForInjectable from "../../common/cluster/request-namespace-list-permissions.injectable";
import createAuthorizationReviewInjectable from "../../common/cluster/create-authorization-review.injectable";
import listNamespacesInjectable from "../../common/cluster/list-namespaces.injectable";
import createContextHandlerInjectable from "../context-handler/create-context-handler.injectable";
import type { ClusterContextHandler } from "../context-handler/context-handler";
@ -43,8 +43,8 @@ describe("create clusters", () => {
di.override(kubectlDownloadingNormalizedArchInjectable, () => "amd64");
di.override(normalizedPlatformInjectable, () => "darwin");
di.override(broadcastMessageInjectable, () => async () => {});
di.override(authorizationReviewInjectable, () => () => () => Promise.resolve(true));
di.override(requestNamespaceListPermissionsForInjectable, () => () => async () => () => true);
di.override(createAuthorizationReviewInjectable, () => () => () => Promise.resolve(true));
di.override(listNamespacesInjectable, () => () => () => Promise.resolve([ "default" ]));
di.override(createContextHandlerInjectable, () => (cluster) => ({
restartServer: jest.fn(),

4
src/main/create-cluster/create-cluster.injectable.ts
View File

@ -10,7 +10,7 @@ import createKubeconfigManagerInjectable from "../kubeconfig-manager/create-kube
import createKubectlInjectable from "../kubectl/create-kubectl.injectable";
import createContextHandlerInjectable from "../context-handler/create-context-handler.injectable";
import { createClusterInjectionToken } from "../../common/cluster/create-cluster-injection-token";
import authorizationReviewInjectable from "../../common/cluster/authorization-review.injectable";
import createAuthorizationReviewInjectable from "../../common/cluster/create-authorization-review.injectable";
import listNamespacesInjectable from "../../common/cluster/list-namespaces.injectable";
import createListApiResourcesInjectable from "../cluster/request-api-resources.injectable";
import loggerInjectable from "../../common/logger.injectable";
@ -29,7 +29,7 @@ const createClusterInjectable = getInjectable({
createKubeconfigManager: di.inject(createKubeconfigManagerInjectable),
createKubectl: di.inject(createKubectlInjectable),
createContextHandler: di.inject(createContextHandlerInjectable),
createAuthorizationReview: di.inject(authorizationReviewInjectable),
createAuthorizationReview: di.inject(createAuthorizationReviewInjectable),
requestNamespaceListPermissionsFor: di.inject(requestNamespaceListPermissionsForInjectable),
requestApiResources: di.inject(createListApiResourcesInjectable),
createListNamespaces: di.inject(listNamespacesInjectable),