1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

Remove dead code

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne Savolainen 2022-08-25 10:33:38 +03:00 committed by Sebastian Malton
parent f6d1909d4d
commit dde628b027
2 changed files with 51 additions and 65 deletions

View File

@ -34,7 +34,6 @@ interface Dependencies {
} }
const NonInjectedReleaseDetailsContent = observer(({ model }: Dependencies & ReleaseDetailsContentProps) => { const NonInjectedReleaseDetailsContent = observer(({ model }: Dependencies & ReleaseDetailsContentProps) => {
const isLoading = model.isLoading.get();
const failedToLoad = model.failedToLoad.get(); const failedToLoad = model.failedToLoad.get();
if (failedToLoad) { if (failedToLoad) {
@ -43,9 +42,6 @@ const NonInjectedReleaseDetailsContent = observer(({ model }: Dependencies & Rel
return ( return (
(isLoading ? (
<Spinner center data-testid="helm-release-detail-content-spinner" />
) : (
<div> <div>
<DrawerItem name="Chart" className="chart"> <DrawerItem name="Chart" className="chart">
<div className="flex gaps align-center"> <div className="flex gaps align-center">
@ -105,7 +101,6 @@ const NonInjectedReleaseDetailsContent = observer(({ model }: Dependencies & Rel
</div> </div>
)} )}
</div> </div>
))
); );
}); });

View File

@ -103,7 +103,6 @@ export class ReleaseDetailsModel {
private detailedRelease = observable.box<DetailedHelmRelease | undefined>(); private detailedRelease = observable.box<DetailedHelmRelease | undefined>();
readonly isLoading = observable.box(false);
readonly failedToLoad = observable.box(false); readonly failedToLoad = observable.box(false);
readonly configuration: ConfigurationInput = { readonly configuration: ConfigurationInput = {
@ -171,10 +170,6 @@ export class ReleaseDetailsModel {
}; };
load = async () => { load = async () => {
runInAction(() => {
this.isLoading.set(true);
});
const { name, namespace } = this.dependencies.targetRelease; const { name, namespace } = this.dependencies.targetRelease;
const result = await this.dependencies.callForHelmRelease( const result = await this.dependencies.callForHelmRelease(
@ -195,10 +190,6 @@ export class ReleaseDetailsModel {
}); });
await this.loadConfiguration(); await this.loadConfiguration();
runInAction(() => {
this.isLoading.set(false);
});
}; };
private loadConfiguration = async () => { private loadConfiguration = async () => {