hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Remove dead code

Browse Source 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne Savolainen 2022-08-25 10:33:38 +03:00 committed by Sebastian Malton
parent f6d1909d4d
commit dde628b027
2 changed files with 51 additions and 65 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

107
src/renderer/components/+helm-releases/release-details/release-details-content.tsx
View File

@ -34,7 +34,6 @@ interface Dependencies {
} }
const NonInjectedReleaseDetailsContent = observer(({ model }: Dependencies & ReleaseDetailsContentProps) => { const NonInjectedReleaseDetailsContent = observer(({ model }: Dependencies & ReleaseDetailsContentProps) => {
const isLoading = model.isLoading.get();
const failedToLoad = model.failedToLoad.get(); const failedToLoad = model.failedToLoad.get();
if (failedToLoad) { if (failedToLoad) {
@ -43,69 +42,65 @@ const NonInjectedReleaseDetailsContent = observer(({ model }: Dependencies & Rel
return ( return (
(isLoading ? ( <div>
<Spinner center data-testid="helm-release-detail-content-spinner" /> <DrawerItem name="Chart" className="chart">
) : ( <div className="flex gaps align-center">
<div> <span>{model.release.chart}</span>
<DrawerItem name="Chart" className="chart">
<div className="flex gaps align-center">
<span>{model.release.chart}</span>
<Button <Button
primary primary
label="Upgrade" label="Upgrade"
className="box right upgrade" className="box right upgrade"
onClick={model.startUpgradeProcess} onClick={model.startUpgradeProcess}
data-testid="helm-release-upgrade-button" data-testid="helm-release-upgrade-button"
/>
</div>
</DrawerItem>
<DrawerItem name="Updated">
{model.release.getUpdated()}
{` ago (${model.release.updated})`}
</DrawerItem>
<DrawerItem name="Namespace">{model.release.getNs()}</DrawerItem>
<DrawerItem name="Version" onClick={stopPropagation}>
<div className="version flex gaps align-center">
<span>{model.release.getVersion()}</span>
</div>
</DrawerItem>
<DrawerItem
name="Status"
className="status"
labelsOnly>
<Badge
label={model.release.getStatus()}
className={kebabCase(model.release.getStatus())}
/> />
</DrawerItem> </div>
</DrawerItem>
<ReleaseValues <DrawerItem name="Updated">
configuration={model.configuration} {model.release.getUpdated()}
onlyUserSuppliedValuesAreShown={ {` ago (${model.release.updated})`}
model.onlyUserSuppliedValuesAreShown </DrawerItem>
}
<DrawerItem name="Namespace">{model.release.getNs()}</DrawerItem>
<DrawerItem name="Version" onClick={stopPropagation}>
<div className="version flex gaps align-center">
<span>{model.release.getVersion()}</span>
</div>
</DrawerItem>
<DrawerItem
name="Status"
className="status"
labelsOnly>
<Badge
label={model.release.getStatus()}
className={kebabCase(model.release.getStatus())}
/> />
</DrawerItem>
<DrawerTitle>Notes</DrawerTitle> <ReleaseValues
configuration={model.configuration}
onlyUserSuppliedValuesAreShown={
model.onlyUserSuppliedValuesAreShown
}
/>
{model.notes && <div className="notes">{model.notes}</div>} <DrawerTitle>Notes</DrawerTitle>
<DrawerTitle>Resources</DrawerTitle> {model.notes && <div className="notes">{model.notes}</div>}
{model.groupedResources.length > 0 && ( <DrawerTitle>Resources</DrawerTitle>
<div className="resources">
{model.groupedResources.map((group) => ( {model.groupedResources.length > 0 && (
<ResourceGroup key={group.kind} group={group} /> <div className="resources">
))} {model.groupedResources.map((group) => (
</div> <ResourceGroup key={group.kind} group={group} />
)} ))}
</div> </div>
)) )}
</div>
); );
}); });

9
src/renderer/components/+helm-releases/release-details/release-details-model/release-details-model.injectable.tsx
View File

@ -103,7 +103,6 @@ export class ReleaseDetailsModel {
private detailedRelease = observable.box<DetailedHelmRelease | undefined>(); private detailedRelease = observable.box<DetailedHelmRelease | undefined>();
readonly isLoading = observable.box(false);
readonly failedToLoad = observable.box(false); readonly failedToLoad = observable.box(false);
readonly configuration: ConfigurationInput = { readonly configuration: ConfigurationInput = {
@ -171,10 +170,6 @@ export class ReleaseDetailsModel {
}; };
load = async () => { load = async () => {
runInAction(() => {
this.isLoading.set(true);
});
const { name, namespace } = this.dependencies.targetRelease; const { name, namespace } = this.dependencies.targetRelease;
const result = await this.dependencies.callForHelmRelease( const result = await this.dependencies.callForHelmRelease(
@ -195,10 +190,6 @@ export class ReleaseDetailsModel {
}); });
await this.loadConfiguration(); await this.loadConfiguration();
runInAction(() => {
this.isLoading.set(false);
});
}; };
private loadConfiguration = async () => { private loadConfiguration = async () => {