hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Don't read chartData.values until after it is checked

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2021-10-07 11:36:53 -04:00
parent 58f7bcb38d
commit dfc7470e6c
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/renderer/components/dock/install-chart.tsx
View File

@ -55,10 +55,6 @@ export class InstallChart extends Component<Props> {
makeObservable(this); makeObservable(this);
} }
get values() {
return this.chartData.values;
}
get chartData() { get chartData() {
return installChartStore.getData(this.tabId); return installChartStore.getData(this.tabId);
} }
@ -135,7 +131,7 @@ export class InstallChart extends Component<Props> {
}; };
render() { render() {
const { tabId, chartData, values, versions, install } = this; const { tabId, chartData, versions, install } = this;
if (chartData?.values === undefined || !versions) { if (chartData?.values === undefined || !versions) {
return <Spinner center />; return <Spinner center />;
@ -215,7 +211,7 @@ export class InstallChart extends Component<Props> {
/> />
<EditorPanel <EditorPanel
tabId={tabId} tabId={tabId}
value={values} value={chartData.values}
onChange={this.onValuesChange} onChange={this.onValuesChange}
/> />
</div> </div>