hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Simplify unit tests for composite

Browse Source 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-turso 2022-10-24 12:24:07 +03:00
parent 4eec9330eb
commit e9d951920c
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/common/utils/composite/get-composite/get-composite.test.ts
View File

@ -15,19 +15,17 @@ interface SomeItem {
} }
describe("get-composite", () => { describe("get-composite", () => {
it("given items and a specified root id, creates a composite", () => { it("given items and an explicit root id, creates a composite", () => {
const getComposite = getCompositeFor<SomeItem>({
rootId: "some-root-id",
getId: (x) => x.id,
getParentId: (x) => x.parentId,
});
const someRootItem = { const someRootItem = {
id: "some-root-id", id: "some-root-id",
parentId: undefined,
someProperty: "some-root-content", someProperty: "some-root-content",
}; };
const someIrrelevantRootItem = {
id: "some-irrelevant-root-id",
someProperty: "some-other-root-content",
};
const someItem = { const someItem = {
id: "some-id", id: "some-id",
parentId: "some-root-id", parentId: "some-root-id",
@ -40,7 +38,13 @@ describe("get-composite", () => {
someProperty: "some-nested-content", someProperty: "some-nested-content",
}; };
const items = [someRootItem, someItem, someNestedItem]; const items = [someRootItem, someIrrelevantRootItem, someItem, someNestedItem];
const getComposite = getCompositeFor<SomeItem>({
rootId: "some-root-id",
getId: (x) => x.id,
getParentId: (x) => x.parentId,
});
const composite = getComposite(items); const composite = getComposite(items);
@ -67,11 +71,11 @@ describe("get-composite", () => {
}); });
}); });
it("given items and an unspecified root id and single item without parent as root, creates a composite", () => { it("given items and implicit root, creates a composite", () => {
const someRootItem = { const someRootItem = {
id: "some-root-id", id: "some-root-id",
someProperty: "some-root-content", someProperty: "some-root-content",
// Notice: no "parentId" makes this the root. // Notice: no "parentId" makes this the implicit root.
parentId: undefined, parentId: undefined,
}; };