1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

Add quick namespace filtering to Jobs view

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2022-11-30 09:36:32 -05:00
parent 4604198dc9
commit ee886820d9
3 changed files with 41 additions and 16 deletions

View File

@ -18,5 +18,9 @@
&.conditions {
@include job-condition-colors;
}
a.filterNamespace {
border-bottom: unset;
}
}
}

View File

@ -7,13 +7,19 @@ import "./jobs.scss";
import React from "react";
import { observer } from "mobx-react";
import { jobStore } from "./legacy-store";
import { eventStore } from "../+events/legacy-store";
import { KubeObjectListLayout } from "../kube-object-list-layout";
import kebabCase from "lodash/kebabCase";
import { KubeObjectStatusIcon } from "../kube-object-status-icon";
import { SiblingsInTabLayout } from "../layout/siblings-in-tab-layout";
import { KubeObjectAge } from "../kube-object/age";
import type { JobStore } from "./store";
import type { EventStore } from "../+events/store";
import type { FilterByNamespace } from "../+namespaces/namespace-select-filter-model/filter-by-namespace.injectable";
import { prevDefault } from "../../utils";
import { withInjectables } from "@ogre-tools/injectable-react";
import eventStoreInjectable from "../+events/store.injectable";
import filterByNamespaceInjectable from "../+namespaces/namespace-select-filter-model/filter-by-namespace.injectable";
import jobStoreInjectable from "./store.injectable";
enum columnId {
name = "name",
@ -23,9 +29,21 @@ enum columnId {
age = "age",
}
interface Dependencies {
jobStore: JobStore;
eventStore: EventStore;
filterByNamespace: FilterByNamespace;
}
@observer
export class Jobs extends React.Component {
class NonInjectedJobs extends React.Component<Dependencies> {
render() {
const {
eventStore,
filterByNamespace,
jobStore,
} = this.props;
return (
<SiblingsInTabLayout>
<KubeObjectListLayout
@ -57,7 +75,13 @@ export class Jobs extends React.Component {
return [
job.getName(),
job.getNs(),
<a
key="namespace"
className="filterNamespace"
onClick={prevDefault(() => filterByNamespace(job.getNs()))}
>
{job.getNs()}
</a>,
`${job.getCompletions()} / ${job.getDesiredCompletions()}`,
<KubeObjectStatusIcon key="icon" object={job} />,
<KubeObjectAge key="age" object={job} />,
@ -72,3 +96,12 @@ export class Jobs extends React.Component {
);
}
}
export const Jobs = withInjectables<Dependencies>(NonInjectedJobs, {
getProps: (di, props) => ({
...props,
eventStore: di.inject(eventStoreInjectable),
filterByNamespace: di.inject(filterByNamespaceInjectable),
jobStore: di.inject(jobStoreInjectable),
}),
});

View File

@ -1,12 +0,0 @@
/**
* Copyright (c) OpenLens Authors. All rights reserved.
* Licensed under MIT License. See LICENSE in root directory for more information.
*/
import { asLegacyGlobalForExtensionApi } from "../../../extensions/as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api";
import jobStoreInjectable from "./store.injectable";
/**
* @deprecated use `di.inject(jobStoreInjectable)` instead
*/
export const jobStore = asLegacyGlobalForExtensionApi(jobStoreInjectable);