1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Commit Graph

2595 Commits

Author SHA1 Message Date
Iku-turso
289251cdec Wip
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-31 16:16:48 +03:00
Janne Savolainen
077b2089b3
Serialize messages in channels to make IPC not blow up
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-31 10:39:33 +03:00
Janne Savolainen
bafa7377f6
Make typing of higher order function for error suppression not lie
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-31 10:37:32 +03:00
Iku-turso
6411b225c0 Make a primitive argument an object for readability
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-30 14:44:29 +03:00
Iku-turso
ac4642ec04 Make different MessageChannels not require explicit "extends JsonObject"
Note: Non-escaped lint breaks type here for forcing interface over type. Reasonable effort brought no understanding for what is the relevant difference between the two.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-30 13:25:14 +03:00
Iku-turso
2fc30f6ce5 Require requests and responses for RequestChannels be JsonValues for serialization
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-30 13:13:06 +03:00
Iku-turso
c156dcf4ae Require messages for MessageChannels be JsonValues for serialization
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-30 13:13:05 +03:00
Janne Savolainen
81db46f69c
Tweak timing of sentry setup
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-30 10:31:21 +03:00
Janne Savolainen
b8edf8df22
Remove unused variable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-30 10:30:59 +03:00
Janne Savolainen
6103f2a9ef
Tweak typing of request channel listeners to get rid of unexpected undefined
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-27 14:57:54 +03:00
Janne Savolainen
a99f62090a
Revert "Implement requesting from renderer in main"
This reverts commit d3e7899d7900516f3dbfacdb317a453202318305.

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-27 14:57:53 +03:00
Janne Savolainen
6c310034c2
Implement requesting from renderer in main
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-27 14:51:16 +03:00
Janne Savolainen
2c38a65da8
Introduce tests for requesting from channel in renderer
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-27 14:51:14 +03:00
Iku-turso
7a54a89e80
Separate concept of message and request channels
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-27 14:51:05 +03:00
Iku-turso
c5809d3d0a Implement initial values for sync-boxes
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-25 13:39:48 +03:00
Janne Savolainen
8217ca8883
Remove duplication for disposers
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-25 10:56:27 +03:00
Janne Savolainen
0c7c851c66
Make dependencies readonly
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-25 10:26:22 +03:00
Janne Savolainen
814ae1ceed
Make code for asserting a promise more strict
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-25 10:18:23 +03:00
Janne Savolainen
3480f98391
Revert not required changes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-25 10:08:50 +03:00
Janne Savolainen
241dea63c9
Mark injectable causing side effects
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-25 10:08:50 +03:00
Janne Savolainen
0f43ca0ce6
Make overridden version of application exactly the one required by unit test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-25 10:08:50 +03:00
Janne Savolainen
de8d5eef37
Make higher order function for logging errors support asynchronous rejecting with non error instance
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-25 10:08:50 +03:00
Janne Savolainen
18d13a23ac
Relocate some explicit error handlings to proper level of abstraction
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-24 14:58:11 +03:00
Janne Savolainen
e1733d382a
Introduce higher order function for suppressing errors
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-24 14:55:46 +03:00
Janne Savolainen
790b352900
Tweak test name
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-24 14:49:06 +03:00
Janne Savolainen
8fc922407f
Export type for error logging
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-24 14:48:54 +03:00
Iku-turso
06851d9961 Introduce higher order function to log errors in decorated functions
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-24 11:13:16 +03:00
Iku-turso
ec2d2056cb Make a channel have default type for sent and returned message
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-24 09:02:04 +03:00
Iku-turso
348b214ca0 Make setting of initial state for sync boxes not trigger irrelevant messaging to main
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-23 17:55:46 +03:00
Iku-turso
fc6fc2488c Simplify code for asking of boolean value from user
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-23 15:15:08 +03:00
Iku-turso
21e05d935b Make asking of boolean value from user not require explicit ID for question
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-23 14:56:57 +03:00
Iku-turso
ff20645bbc Introduce dependency to get random IDs
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-23 14:33:20 +03:00
Iku-turso
bff260f97d Enhance name of behaviour
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-23 14:20:12 +03:00
Iku-turso
1b8b84213d Make unit test more strict
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-23 14:18:08 +03:00
Iku-turso
5402f64402 Improve name of behaviour
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-23 14:06:44 +03:00
Iku-turso
b1f577399c Add todo for cleaning unacceptable code encountered
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-23 13:59:09 +03:00
Iku-turso
d463fe2b4b Simplify more and more naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-23 13:59:09 +03:00
Iku-turso
3e5f374122 Simplify even more naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-23 13:59:09 +03:00
Iku-turso
9c5971378b Simplify more naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-23 13:59:08 +03:00
Iku-turso
4b14ec10fa Simplify naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-23 13:59:08 +03:00
Janne Savolainen
d677a1bf81
Make Animate deterministic in unit tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-20 15:43:09 +03:00
Janne Savolainen
27fbaa1a0c
Fix code style
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-20 14:39:52 +03:00
Janne Savolainen
4edc8e6cc9
Remove redundant overrides
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-20 14:29:43 +03:00
Janne Savolainen
558d39d65d
Improve name of test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-20 14:29:31 +03:00
Janne Savolainen
552df3155b
Simplify test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-20 14:26:43 +03:00
Janne Savolainen
e9a851a8cb
Remove unimplemented scenario from test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-20 14:16:56 +03:00
Janne Savolainen
1180b4dcc8
Add TODO
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-20 14:14:55 +03:00
Janne Savolainen
d705e92b17
Consolidate names of directories
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-20 14:11:20 +03:00
Janne Savolainen
aa0ea4d4b4
Tweak message of question from user
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-20 14:11:19 +03:00
Janne Savolainen
f3bdabb777
Add missing global override
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-20 14:11:17 +03:00