Janne Savolainen
350f07b457
Introduce first unit test made possible because of recently demonstrated changes
...
Key changes were:
- Introduction of dependencies as interfaces to permit stubbing in general (Dependency Inversion Principle)
- Introduction of segregated interfaces to only require stubbing of minimal stuff (Interface Segregation Principle)
Signed-off-by: Janne Savolainen <janne.savolainen@houston-inc.com>
2021-12-04 12:16:33 +02:00
Janne Savolainen
94d3f6b5fb
Make typing of dependency functions more strict
...
Signed-off-by: Janne Savolainen <janne.savolainen@houston-inc.com>
2021-12-04 12:16:33 +02:00
Janne Savolainen
a0f0d3e811
Improve naming of type parameter
...
Signed-off-by: Janne Savolainen <janne.savolainen@houston-inc.com>
2021-12-04 12:16:33 +02:00
Janne Savolainen
73e3dd95f4
Make another dependency a segregated interface instead of concrete instance
...
Notice how interface is in fact segregated, i.e. it only advertises the minimal properties currently required.
With this we satisfy Interface Segregation Principle and thus permit e.g. minimal requirement for stubbing in future unit tests.
Signed-off-by: Janne Savolainen <janne.savolainen@houston-inc.com>
2021-12-04 12:16:33 +02:00
Janne Savolainen
d9e8821d33
Simplify a way of getting cluster name
...
Signed-off-by: Janne Savolainen <janne.savolainen@houston-inc.com>
2021-12-04 12:16:33 +02:00
Janne Savolainen
29d0634729
Demonstrate even step further to have an interface as dependency instead of concrete instance
...
Signed-off-by: Janne Savolainen <janne.savolainen@houston-inc.com>
2021-12-04 12:16:33 +02:00
Janne Savolainen
91b14ee3fc
Demonstrate a step further to have an interface as dependency instead of concrete instance
...
With this we get yet closer to satisfaction of Dependency Inversion Principle.
Signed-off-by: Janne Savolainen <janne.savolainen@houston-inc.com>
2021-12-04 12:16:33 +02:00
Janne Savolainen
8d0abcc9d5
Demonstrate naive way to make component not responsible of it's dependencies and not use global shared state
...
This is to make a step towards satisfaction of Dependency Inversion Principle. It's not fully satisfied because we still depend on concrete instances of classes instead of interfaces.
This will start chain of thought to pursue warm and friendly unit testing and introduction of SOLID principles.
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
2021-12-04 12:16:33 +02:00
Janne Savolainen
b07b8dc096
Rename method to not be misleading
...
Signed-off-by: Janne Savolainen <janne.savolainen@houston-inc.com>
2021-12-04 11:55:19 +02:00
Janne Savolainen
10eb95ae67
Implement breadcrumbs for deleting different kube objects
...
This was done in a naive way by disregarding stuff such as:
- Avoidance of shared global state (dependency inversion principle)
- Unit testing
- Minimal implementation over defensive code (elvis, just in case)
- Full understanding for use cases of all different kube objects
Signed-off-by: Janne Savolainen <janne.savolainen@houston-inc.com>
2021-12-04 11:55:07 +02:00
Sebastian Malton
304941d397
Fix IngressApi being registered with a wrong new apiBase ( #4485 )
2021-12-03 15:19:01 -05:00
dependabot[bot]
7973f4bce2
Bump @types/webpack from 4.41.31 to 4.41.32 ( #4499 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-03 14:33:05 -05:00
dependabot[bot]
9aadb721c9
Bump webpack-dev-server from 3.11.2 to 3.11.3 ( #4498 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-03 12:49:52 -05:00
Sebastian Malton
7dfd4d586c
Fix error notifications not being displayed for CreateResource tab ( #4502 )
2021-12-03 12:49:42 -05:00
dependabot[bot]
4f291ad077
Bump moment-timezone from 0.5.33 to 0.5.34 ( #4489 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-03 11:50:05 -05:00
dependabot[bot]
122f14f32b
Bump react-material-ui-carousel from 2.3.5 to 2.3.8 ( #4491 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-03 11:49:57 -05:00
Alex Andreev
d73df7fe0d
Show active hotbar on bottom ( #4476 )
...
- Extends extension API to support choosing sides for bottom bar entries
2021-12-03 09:41:08 -05:00
dependabot[bot]
39955b623f
Bump sharp from 0.29.2 to 0.29.3 ( #4495 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-03 08:59:25 -05:00
dependabot[bot]
8055ba261b
Bump @types/url-parse from 1.4.4 to 1.4.5 ( #4494 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Malton <sebastian@malton.name>
2021-12-03 08:59:18 -05:00
Jim Ehrismann
29c9c73a13
catch app.getPath() errors ( #4492 )
...
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
2021-12-02 20:52:03 -05:00
dependabot[bot]
ca549e0577
Bump @types/lodash from 4.14.176 to 4.14.177 ( #4487 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-02 16:49:16 -05:00
dependabot[bot]
851ad0e36b
Bump @types/fs-extra from 9.0.1 to 9.0.13 ( #4474 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-02 16:09:48 -05:00
dependabot[bot]
1c16b697ae
Bump joi from 17.4.2 to 17.5.0 ( #4486 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Malton <sebastian@malton.name>
2021-12-02 16:09:38 -05:00
dependabot[bot]
b350ea5900
Bump typedoc from 0.22.7 to 0.22.10 ( #4444 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Malton <sebastian@malton.name>
2021-12-02 15:38:17 -05:00
dependabot[bot]
020116516e
Bump @types/react-table from 7.7.7 to 7.7.8 ( #4471 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-02 12:36:30 -05:00
dependabot[bot]
aa6db81321
Bump @types/readable-stream from 2.3.11 to 2.3.12 ( #4428 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-02 12:36:10 -05:00
Sebastian Malton
1636be71d5
Don't emit build_id metadata on RPM builds ( #4464 )
2021-12-02 09:37:13 -05:00
Jim Ehrismann
f78d9c5fc2
add debug for locating startup issues ( #4481 )
2021-12-02 09:34:06 -05:00
Alex Andreev
6e543961ac
Fixing unexpected avatar width shrink ( #4483 )
2021-12-02 09:12:44 -05:00
Panu Horsmalahti
696986b7e6
Use PartialDeep for patch type ( #4420 )
...
* Use PartialDeep for patch type.
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
* Add test. Fix typing.
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
* Fix lint.
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
2021-12-02 15:28:28 +02:00
Alex Andreev
f02018c1e7
Fix light theme pin icon visibility ( #4477 )
...
* Remove what-input dependency
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Use focus-visible prop and color fix in Icon
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
2021-12-02 11:12:16 +03:00
Sebastian Malton
4c16b7020d
Fix KubeApi.create not populating kind and apiVersion ( #4478 )
2021-12-01 15:57:08 -05:00
Alex Andreev
9ce91884c2
Replacing <Avatar/> component by native one ( #4452 )
2021-12-01 08:28:56 -05:00
Sebastian Malton
80eeffc229
Log cluster model if adding a cluster fails when syncing from catalog ( #4463 )
2021-12-01 08:08:48 -05:00
Sebastian Malton
4257fce2f0
Fix NetworkPolicy engresses not having node/pod selectors displayed ( #4467 )
2021-12-01 08:08:26 -05:00
dependabot[bot]
cd2f5094dc
Bump @types/sharp from 0.29.2 to 0.29.4 ( #4468 )
...
Bumps [@types/sharp](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sharp ) from 0.29.2 to 0.29.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sharp )
---
updated-dependencies:
- dependency-name: "@types/sharp"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-01 09:58:18 +03:00
dependabot[bot]
f404b953cd
Bump eslint-plugin-react-hooks from 4.2.0 to 4.3.0 ( #4429 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-11-30 17:12:00 -05:00
dependabot[bot]
cfa21deece
Bump eslint-plugin-react from 7.26.1 to 7.27.1 ( #4466 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-11-30 15:07:25 -05:00
Jan Jansen
120134a084
Prefer usage of preference over autoselection ( #4436 )
2021-11-30 13:51:41 -05:00
dependabot[bot]
31946daea3
Bump electron-builder from 22.13.1 to 22.14.5 ( #4457 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-11-30 13:51:20 -05:00
Sebastian Malton
29220c1c73
Fix getLatestApiPrefixGroup to not fail when options.apiBase is not provided ( #4462 )
2021-11-30 11:27:20 -05:00
Juho Heikka
37b8fe45f5
Center text in notifications ( #4461 )
...
Signed-off-by: Juho Heikka <juho.heikka@gmail.com>
2021-11-30 18:01:04 +02:00
Sebastian Malton
2f14b7a70a
Refactor Nodes view metrics renderer ( #3990 )
2021-11-30 10:30:54 -05:00
Sebastian Malton
f0274d08a4
Add Check-For-Updates in menu and some notifications ( #4437 )
2021-11-30 10:30:42 -05:00
Sebastian Malton
7ce4a87ac8
Add support for resizing Drawers ( #4440 )
...
Co-authored-by: Alex Andreev <alex.andreev.email@gmail.com>
2021-11-30 09:09:19 -05:00
Sebastian Malton
df46dd9ef6
Fix not being able to remove role bindings via the UI ( #4394 )
2021-11-30 09:06:54 -05:00
Sebastian Malton
2ab9aeb83c
Correctly handle promises and rejections around cluster connection ( #4216 )
2021-11-30 09:05:34 -05:00
dependabot[bot]
bb30bdc750
Bump @types/uuid from 8.3.1 to 8.3.3 ( #4445 )
...
Bumps [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid ) from 8.3.1 to 8.3.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid )
---
updated-dependencies:
- dependency-name: "@types/uuid"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-11-30 14:48:31 +03:00
Sebastian Malton
0286faf387
Fix detail views not watching child components ( #4345 )
...
* Fix detail views not watching child components
- Add subscribeStores calls to all relavent details
- Add support for tracking overlapping subscribes as an optimization
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Resolve PR comments
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Detect the adding of a namespace when selected namespaces change
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update debug log
Signed-off-by: Sebastian Malton <sebastian@malton.name>
2021-11-29 17:25:35 -05:00
Alex Andreev
8ff7c03993
Fix hotbar items drag-n-drop bugs ( #4433 )
2021-11-29 12:45:32 -05:00