Commit Graph
2572 Commits
Author SHA1 Message Date
Janne SavolainenandMikko Aspiala 37e600cba9 Tweak name of timeslot to make it more apparent that new content for application load can be added
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:14 +03:00
Janne SavolainenandMikko Aspiala 12839c7784 Extract injectable with side-effect for exact overriding
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:14 +03:00
Janne SavolainenandMikko Aspiala ff87f627aa Tweak types
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:13 +03:00
Janne SavolainenandMikko Aspiala b179e0f6a9 Revert code-style changes
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:13 +03:00
Janne SavolainenandMikko Aspiala 07f01d52a5 Tweak naming of runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:13 +03:00
Janne SavolainenandMikko Aspiala 0f067da6f4 Tweak typing
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:13 +03:00
Janne SavolainenandMikko Aspiala 96b5771b08 Extract responsibility to injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:13 +03:00
Janne SavolainenandMikko Aspiala 678043e34e Flag injectable causing side effects
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:13 +03:00
Janne SavolainenandMikko Aspiala 3c7b2c9013 Extract responsibility of setting dependencies to own injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:13 +03:00
Janne SavolainenandMikko Aspiala 88fe9b1b75 Remove global state
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:12 +03:00
Janne SavolainenandMikko Aspiala fc04a4e17f Add empty mocks comply to lint
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:12 +03:00
Janne SavolainenandMikko Aspiala 767eb75c2b Kill dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:12 +03:00
Janne SavolainenandMikko Aspiala 32a128d44b Simplify naming
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:12 +03:00
Janne SavolainenandMikko Aspiala 1810a330cf Switch to using dependency over using explicit side-effect
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:12 +03:00
Janne SavolainenandMikko Aspiala 82336d7a12 Remove code-style changes that are not welcome
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:12 +03:00
Janne SavolainenandMikko Aspiala 5b65a93849 Fix code style
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:11 +03:00
Janne SavolainenandMikko Aspiala 1867d22fc9 Update yarn.lock after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:11 +03:00
Janne SavolainenandMikko Aspiala 32bc853279 Introduce reactive way to get theme from operating system
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:11 +03:00
Janne SavolainenandMikko Aspiala c7dba52cd0 Make startable stoppable support async starting
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:11 +03:00
Janne SavolainenandMikko Aspiala 952ff1deb9 Make script for running unit tests support targeting
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:11 +03:00
Janne SavolainenandMikko Aspiala 16b91773ee Extract helpers for testing promises to test-utils
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:11 +03:00
Janne SavolainenandMikko Aspiala 395ce7ab49 Flag injectable causing side-effect
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:10 +03:00
Janne SavolainenandMikko Aspiala 551736ac2a Simplify directory structures for runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:10 +03:00
Janne SavolainenandMikko Aspiala 55d1471c10 Consolidate code for application window
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:28:08 +03:00
Janne SavolainenandMikko Aspiala 5ac9b2aa87 Extract responsibilities of WindowManager as injectables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:27:17 +03:00
Janne SavolainenandMikko Aspiala 5842db2cc3 Make quit of hidden Lens not blow up
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:36 +03:00
Janne SavolainenandMikko Aspiala ec279d4f5c Make it possible to not stop something that was never started
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:36 +03:00
Janne SavolainenandMikko Aspiala d6a0880df0 Tweak timeslot of a runnable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:36 +03:00
Janne SavolainenandMikko Aspiala 5f51c90ca3 Fix missing injectable postfix in file name
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:36 +03:00
Janne SavolainenandMikko Aspiala b3dab6b781 Fix application quit by calling Electron's event.preventDefault in a very specific way and preventing async
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:36 +03:00
Janne SavolainenandMikko Aspiala 98cecaa91c Kill dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:35 +03:00
Janne SavolainenandMikko Aspiala 25a48f3d7d Make runnables for before application is ready synchronous as this is technical limitation of Electron
See: https://github.com/electron/electron/issues/21370

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:35 +03:00
Janne SavolainenandMikko Aspiala d4b2ff992a Introduce a way to run many synchronous runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:35 +03:00
Janne SavolainenandMikko Aspiala 497c5258e6 Make splash screen not blow up by providing compile-time environment variables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:35 +03:00
Janne SavolainenandMikko Aspiala 0d41eabb64 Extract tray icon path as injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:35 +03:00
Janne SavolainenandMikko Aspiala 76e6718874 Tweak timing of runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:35 +03:00
Janne SavolainenandMikko Aspiala 579dfd2d0b Deprecate another var with injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:35 +03:00
Janne SavolainenandMikko Aspiala d93080b4e5 Consolidate to use injectable instead of var for static file directory
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:34 +03:00
Janne SavolainenandMikko Aspiala 90c52a98b2 Remove redundant import
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:34 +03:00
Janne SavolainenandMikko Aspiala 7f0eb07cc5 Ensure that LensProxy is setupped before starting the main window
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:34 +03:00
Janne SavolainenandMikko Aspiala 00a5e54ce8 Fix setupping of sentry after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:34 +03:00
Janne SavolainenandMikko Aspiala c6c128e890 Kludge around test setup which is difficult because of circular dependencies
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:34 +03:00
Janne SavolainenandMikko Aspiala 79e56cb187 Fix error about multiple states for React Router being present at once
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:34 +03:00
Janne SavolainenandMikko Aspiala cef683903d Fix code style
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:33 +03:00
Janne SavolainenandMikko Aspiala a3f139a40d Adapt vars after merge
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:33 +03:00
Janne SavolainenandMikko Aspiala 81ddf1153c Update snapshot
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:33 +03:00
Iku-tursoandJanne Savolainen 2e58058904 Add general override for behavioural tests
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:25:33 +03:00
Iku-tursoandJanne Savolainen 823cab8170 Make navigating to Helm Charts not blow up
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:25:33 +03:00
Iku-tursoandJanne Savolainen 203418ac37 Make startableStoppables have ID for better error logging
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:25:33 +03:00
Iku-tursoandJanne Savolainen 57a1677c48 Consolidate runnables related to Electron
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:25:32 +03:00