Janne Savolainen
|
4e09ebdd33
|
Remove not needed properties from test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:29:27 +02:00 |
|
Janne Savolainen
|
db5873319f
|
Make mechanism of creating HTTP response an implementation detail
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:29:26 +02:00 |
|
Janne Savolainen
|
40bf8e757b
|
Remove duplicate license header
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:29:26 +02:00 |
|
Janne Savolainen
|
b57178157c
|
Add test for throwing route handler
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:29:26 +02:00 |
|
Janne Savolainen
|
878488f4d0
|
Rename test for accuracy
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:29:26 +02:00 |
|
Janne Savolainen
|
adde13237a
|
Make code cleaner
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:29:24 +02:00 |
|
Janne Savolainen
|
9117bc2760
|
Make typing of routes support synchronous values
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:25:10 +02:00 |
|
Janne Savolainen
|
3f28a09fa1
|
Fix incorrect return value of updateRelease
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:24:16 +02:00 |
|
Janne Savolainen
|
79587514d8
|
Make response of route typed
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:24:13 +02:00 |
|
Janne Savolainen
|
4b76327489
|
Introduce healthy abstraction between back-end routes and route handlers
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:20:53 +02:00 |
|
Janne Savolainen
|
d099256c9a
|
Make routes wait until all asynchronous stuff are done
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:11:11 +02:00 |
|
Janne Savolainen
|
afa9c10969
|
Make adding routes private for router
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:11:11 +02:00 |
|
Janne Savolainen
|
711516cccf
|
Switch to using injectable to setup route for serving static files
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 09:11:08 +02:00 |
|
Janne Savolainen
|
086db9fce7
|
Add global override for reading file to make it not required where not interesting
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:56:54 +02:00 |
|
Janne Savolainen
|
3ab356b97f
|
Switch to using injectable to setup route for getting version
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:56:52 +02:00 |
|
Janne Savolainen
|
c41d10de02
|
Switch to using injectable to setup route for getting service account
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:55:25 +02:00 |
|
Janne Savolainen
|
ef92a98755
|
Switch to using injectable to setup route for metrics
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:55:25 +02:00 |
|
Janne Savolainen
|
4bac753f76
|
Consolidate start port forward route to use injection token for registering route
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:55:24 +02:00 |
|
Janne Savolainen
|
398d980047
|
Switch to using injectable to setup route for getting current port forward
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:24 +02:00 |
|
Janne Savolainen
|
1853c23e5e
|
Switch to using injectable to setup route for stopping current port forward
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:24 +02:00 |
|
Janne Savolainen
|
fc582d77a2
|
Switch to using injectable to setup route for patching resource
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:24 +02:00 |
|
Janne Savolainen
|
ae3b49a9c1
|
Switch to using injectable to setup route for applying resource
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:24 +02:00 |
|
Janne Savolainen
|
f15dd3b3b1
|
Remove HelmRoute for not being used anymore
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:24 +02:00 |
|
Janne Savolainen
|
72ec1d09a7
|
Switch to using injectable to setup route for deleting release
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:24 +02:00 |
|
Janne Savolainen
|
1712eab5b9
|
Switch to using injectable to setup route for getting release history
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:24 +02:00 |
|
Janne Savolainen
|
b56d25b9a1
|
Switch to using injectable to setup route for getting release values
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:23 +02:00 |
|
Janne Savolainen
|
06be2951ee
|
Switch to using injectable to setup route for getting release
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:23 +02:00 |
|
Janne Savolainen
|
4a200dad5a
|
Switch to using injectable to setup route for listing releases
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:23 +02:00 |
|
Janne Savolainen
|
80d07edc66
|
Switch to using injectable to setup route for rollbacking release
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:23 +02:00 |
|
Janne Savolainen
|
ea561ff025
|
Switch to using injectable to setup route for updating release
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:23 +02:00 |
|
Janne Savolainen
|
3d803ff1c2
|
Switch to using injectable to setup route for installing chart
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:23 +02:00 |
|
Janne Savolainen
|
cca9c4b498
|
Switch to using injectable to setup route for get chart values
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:23 +02:00 |
|
Janne Savolainen
|
6729f46542
|
Switch to using injectable to setup route for get chart
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:22 +02:00 |
|
Janne Savolainen
|
9aefdf3dc6
|
Switch to using injectable to setup route for list charts
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:22 +02:00 |
|
Janne Savolainen
|
fc9e9ee2b7
|
Make registration of back-end routes happen using injectable
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-11 08:53:21 +02:00 |
|
Janne Savolainen
|
125a47a56d
|
Replace WorkloadsOverviewDetailRegistry with reactive solution (#4817)
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-03-04 10:04:38 +02:00 |
|
Janne Savolainen
|
54b87efd89
|
Replace KubeObjectStatusRegistry with reactive solution (#4815)
|
2022-03-03 07:55:57 -05:00 |
|
 Janne SavolainenandMikko Aspiala
|
b65f6e00ec
|
Update injectable library (#4842)
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
|
2022-02-25 11:10:13 -05:00 |
|
 Janne SavolainenandMikko Aspiala
|
81819dbbe9
|
Revert accidental breaking change in Extension API (#4904)
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-02-23 13:26:14 +02:00 |
|
Janne Savolainen
|
668ac58cb3
|
Consolidate way of passing items to ItemListLayout (#4850)
|
2022-02-11 09:32:14 -05:00 |
|
Janne Savolainen
|
9ea3c94c5a
|
Upgrade injectable to fix observation of asyncComputed when invalidated before ever observed (#4828)
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-02-07 14:02:06 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
09824a6e01
|
Prevent creation of dynamic components where withInjectables use type parameters to make React not re-mount because of dynamic components being different (#4808)
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-02-03 13:26:14 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
e58d9b631a
|
Fix bugs in ItemListLayouts/KubeObjectListLayouts (#4792)
* Fix virtual list behaviour in item list layout by making table rows observer
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make selecting item in ItemListLayout not scroll to top
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix scrolling to top when selecting all items in item list layout
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix refreshing release values when release is unselected
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove noisy debugging
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix sorting of table rows
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Replace avoidable asyncComputed with normal computed
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Revert unnecessary code style changes
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix render-storm in Events
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix missing key in React array
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-02-02 16:46:07 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
e8205a64b9
|
Fix bugs in helm releases (#4785)
* Fix opening of upgrade release tab
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Bring back ability to rollback to specific revision
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix helm releases not updating after rollback
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix helm releases not updating after upgrade
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-02-01 16:18:43 +02:00 |
|
 Janne SavolainenandSebastian Malton
|
ac42a6565f
|
Replace kube object menu registry with reactive solution (#4731)
Co-authored-by: Sebastian Malton <sebastian@malton.name>
|
2022-01-31 10:16:29 -05:00 |
|
Janne Savolainen
|
09b33633f7
|
Replace StatusBarRegistry with reactive solution (#4728)
|
2022-01-28 08:40:58 -05:00 |
|
 Janne SavolainenandMikko Aspiala
|
4f5a2988cb
|
Fix infinite render loop in release details (#4710)
* Fix infinite render loop in release details by replacing stateful, UI-triggered releaseStore with reactive async computed
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove unnecessary return
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove empty lines
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Allow injection of history
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make data required for opening of release details a dependency to make sure it's present
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make arriving release values not re-render whole details
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-21 16:29:10 +02:00 |
|
Janne Savolainen
|
589472c2b5
|
Shorten license header to reduce amount of clutter in top of the files (#4709)
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-18 10:18:10 +02:00 |
|
Janne Savolainen
|
84b1d9e703
|
Temporary disable failing integration tests to allow merging and solve issue in separate PR
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-17 18:24:17 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
1e772e5303
|
Fix import
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-14 08:05:22 +02:00 |
|
Janne Savolainen
|
edd9dcd44b
|
Fix duplicate import
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-14 08:04:25 +02:00 |
|
Janne Savolainen
|
00f6d6bc1f
|
Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths
|
2022-01-14 07:59:42 +02:00 |
|
Janne Savolainen
|
7c97303414
|
Remove duplicated LICENSE header
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-14 07:52:37 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
4e2995f979
|
Extract business logic from component while trying to solve re-rendering issue
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-13 09:04:15 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
06379b089b
|
Add TODO
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-13 09:01:34 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
09b52a59d8
|
Fix adding new namespace
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-12 09:06:25 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
ecb93393d1
|
Fix issue with "this"
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-11 16:18:08 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
070750e736
|
Try fixing unit test in windows
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-11 14:51:57 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
883ece7ea2
|
Make unit test not fail on windows
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-11 14:34:46 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
977c6bd2c7
|
Move file to proper directory
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-11 14:05:04 +02:00 |
|
Janne Savolainen
|
0f33ba18d2
|
Simplify function
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-11 14:04:06 +02:00 |
|
Janne Savolainen
|
995983f0b0
|
Fix code style
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-11 14:03:51 +02:00 |
|
Janne Savolainen
|
8d87bd0985
|
Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-11 13:56:23 +02:00 |
|
Janne Savolainen
|
f7f27a8304
|
Merge pull request #4424 from lensapp/issue-3258
Command Palette Improvements
|
2022-01-11 09:20:02 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
a1fd61e41b
|
Mark electron to cause side effects in unit tests
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-11 09:12:23 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
b157bda76b
|
Fix deprecated comment
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-11 09:10:43 +02:00 |
|
Janne Savolainen
|
e1a6d4c4a9
|
Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths
|
2022-01-10 17:13:20 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
d853898a48
|
Update injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-10 16:54:04 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
4b46f1fe02
|
Override a side effect in unit test
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-10 16:54:04 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
ae1d3a2712
|
Revert breaking change
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-10 16:54:04 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
eeff7e488f
|
Fix changing between cluster metrics
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-10 16:54:04 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
4d5e2bd812
|
Remove component observation causing involuntary re-renders
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-10 16:54:03 +02:00 |
|
Janne Savolainen
|
48948c7286
|
Fix endless re-rending of logs
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-10 16:54:03 +02:00 |
|
Janne Savolainen
|
4441d714dd
|
Fix issue with opening of terminal
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-07 19:29:24 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
ff9e9bd169
|
Re-implement some Extension API features using injectables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-07 12:10:02 +02:00 |
|
Janne Savolainen
|
4224937260
|
Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-05 15:04:43 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
9d33fff906
|
Cascade different refactorings to eliminate global shared state from app paths
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-01-05 13:26:49 +02:00 |
|
Janne Savolainen
|
58ea0dc822
|
Merge pull request #4613 from jansav/top-bar-registry
Replace TopBarRegistry with reactive solution
|
2021-12-31 12:03:51 +02:00 |
|
Janne Savolainen
|
71388a0ea3
|
Switch typing of a component to props instead of React.FC
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-31 09:32:24 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
6ca58570b0
|
Replace TopBarRegistry with reactive solution
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-31 09:32:19 +02:00 |
|
Janne Savolainen
|
ed7d2889e2
|
Merge pull request #4615 from jansav/welcome-menu-registry
Replace WelcomeMenuRegistry and WelcomeBannerRegistry with reactive solution
|
2021-12-31 09:28:29 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
c5613a2e6a
|
Remove WelcomeBannerRegistry in favor of reactive solution
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-28 13:55:55 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
04ac2ff3dd
|
Remove WelcomeMenuRegistry in favor of reactive solution
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-28 13:55:54 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
ab4a8c8a1d
|
Convert a class component to functional component
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-28 13:55:50 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
908a40975e
|
Extract minimal dependencies over a god class to satisfy Interface Segregation Principle and make stubbing in unit testing easier
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-28 11:51:35 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
13873f5d85
|
Replace a dependency to full implementation with an interface to allow minimal stubbing
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-28 11:51:34 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
a9189f82e6
|
Stop using global shared state for ExtensionDiscovery and it's relatives
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-28 11:51:34 +02:00 |
|
Janne Savolainen
|
41aacb3db2
|
Merge pull request #4612 from jansav/update-injectable
Adapt to recent simplifications in injectable
|
2021-12-28 11:51:11 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
5325b902b6
|
Fix code style
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-27 14:17:40 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
c2e5df0c84
|
Stop exporting dependencies for being redundant
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-27 14:17:39 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
6f0686e9a4
|
Adapt to changes in injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-27 14:17:38 +02:00 |
|
 Janne SavolainenandMikko Aspiala
|
8a78c73e19
|
Update ogre-tools and async-fn
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-27 14:17:37 +02:00 |
|
Janne Savolainen
|
a711499bb6
|
Update ogre-tools for improved types of withInjectables (#4587)
|
2021-12-17 10:28:26 -05:00 |
|
Janne Savolainen
|
3418c0acfe
|
Merge pull request #4527 from jansav/make-menu-registry-obsolete
Remove MenuRegistry in favour of dependency injection
|
2021-12-16 15:11:30 +02:00 |
|
Janne Savolainen
|
c0a0127d2d
|
Merge pull request #4557 from lensapp/remove-weird-whitespace
Remove all 'NonBreakingSpace' characters from the repo
|
2021-12-16 08:38:55 +02:00 |
|
Janne Savolainen
|
f56f3be79b
|
Merge pull request #4569 from lensapp/issue-4567
Fix crash with InstallChart
|
2021-12-16 08:27:20 +02:00 |
|
Janne Savolainen
|
8337dfd21b
|
Fix test that was accidentally broken
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-16 07:14:16 +02:00 |
|
Janne Savolainen
|
250b301655
|
Revert code style change
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-16 07:14:16 +02:00 |
|
Janne Savolainen
|
a2486da0eb
|
Fix linting
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-16 07:14:15 +02:00 |
|
Janne Savolainen
|
2189679a30
|
Merge remote-tracking branch 'upstream/master' into make-menu-registry-obsolete
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-15 16:14:08 +02:00 |
|