Commit Graph
3092 Commits
Author SHA1 Message Date
Iku-tursoandJanne Savolainen 6f4a6c95fc Remove code made redundant with hiding of preference tabs without content
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-21 08:23:15 +03:00
Iku-tursoandJanne Savolainen ca5e5034e6 Make tab groups and tabs in preferences not render when there is no content
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-21 08:23:15 +03:00
Iku-tursoandJanne Savolainen f48dcba59d Introduce way to find out if composite has a descendant
This will serve eg. hiding of empty preference tab groups.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-21 08:23:15 +03:00
Janne Savolainen dd0e2dc394 Add extensions tab group to preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-21 08:23:15 +03:00
Janne Savolainen fe8bd649c8 Remove dead code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-21 08:23:14 +03:00
Janne Savolainen ed14cdc204 Remove usage of old code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-21 08:23:14 +03:00
Janne Savolainen c7ce675a02 Move code under a Feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-21 08:23:14 +03:00
Janne Savolainen 515ec34c87 Introduce competition for preferences navigation
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-21 08:23:14 +03:00
Janne SavolainenandMikko Aspiala 6d56771404 Introduce utility to find exactly one item from array
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-21 08:23:14 +03:00
Janne SavolainenandMikko Aspiala 69764045aa Remove dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-21 08:23:13 +03:00
Janne Savolainen ffd4b13dcd Revert "Introduce reusable horizontal line"
This reverts commit 4d8c147fe0f1a14bd884f73cf345e7d3a28b954a.

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-21 08:23:13 +03:00
Janne Savolainen ce1adc0695 Tweak more UI of preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:37 +03:00
Janne SavolainenandMikko Aspiala f2de81cf81 Remove dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:37 +03:00
Janne Savolainen 258bfc98e8 Tweak UI for preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:36 +03:00
Janne SavolainenandMikko Aspiala d4cb72ef53 Switch to using competition for terminal preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:36 +03:00
Janne SavolainenandMikko Aspiala 845d4ce1f1 Switch to using competition for telemetry preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:36 +03:00
Janne Savolainen 0a6f1bbbdc Add missing observer to make sure component updates
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:36 +03:00
Janne SavolainenandMikko Aspiala ea07f94e9e Switch to using competition for proxy preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:35 +03:00
Janne SavolainenandMikko Aspiala 17cd5a8097 Switch to using competition for kubernetes preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:35 +03:00
Janne SavolainenandMikko Aspiala aaafbdb4fe Switch to using competition for editor preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:35 +03:00
Janne SavolainenandMikko Aspiala e8b27ee6a5 Switch to using competition for application preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:35 +03:00
Janne SavolainenandMikko Aspiala cd3210ac59 Introduce competition for kubernetes preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:34 +03:00
Janne SavolainenandMikko Aspiala 3c214c6635 Move code related to helm chart preferences under related Feature in preparation for competition
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:32 +03:00
Janne SavolainenandMikko Aspiala bdd945a6d3 Introduce competition for application preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:22 +03:00
Janne SavolainenandMikko Aspiala 0dc45c7ce9 Introduce competition for telemetry preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:22 +03:00
Janne SavolainenandMikko Aspiala b7fe3deaa1 Introduce competition for proxy preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:22 +03:00
Janne SavolainenandMikko Aspiala 00eb003d47 Introduce competition for editor preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:21 +03:00
Janne SavolainenandMikko Aspiala 943bc6db77 Introduce competition for terminal preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:21 +03:00
Janne SavolainenandMikko Aspiala aa90e8e7d2 Introduce competition for preferences as a Feature
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:21 +03:00
Janne SavolainenandMikko Aspiala dfaf90a39f Introduce reusable horizontal line
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:21 +03:00
Iku-tursoandJanne Savolainen 145958364a Consolidate code to check for updates closer to feature
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:20 +03:00
Iku-tursoandJanne Savolainen 27a94f4132 Rename id of menu item to keep it discoverable by existing extensions
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:20 +03:00
Iku-tursoandJanne Savolainen 2c29fb7e00 Add logging for unrecognizable application menu item types
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:20 +03:00
Iku-tursoandJanne Savolainen 66e4ec1f53 Make registrator for application menu items support all known scenarios
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:20 +03:00
Iku-tursoandJanne Savolainen 9f19fdceb2 Simplify getting of composite paths
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:20 +03:00
Iku-tursoandJanne Savolainen f2e6ce22aa Make faked, yet weak, typing a bit stronger
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:19 +03:00
Iku-tursoandJanne Savolainen fc77c41095 Reintroduce non-fatal handling of orphan application menu items
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:19 +03:00
Iku-tursoandJanne Savolainen db774c18d9 Defend against self-referencing composites
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:19 +03:00
Iku-tursoandJanne Savolainen 822f4394fe Make composite able to have custom handler for missing parent ids
This will be useful next for application menu items, where a missing parent id cannot be fatal.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:19 +03:00
Iku-tursoandJanne Savolainen 0e550d496c Simplify creation of composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:18 +03:00
Iku-tursoandJanne Savolainen 9c927b7f2d Update snapshot
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:18 +03:00
Janne SavolainenandMikko Aspiala a8cc1cd17c Simplify hierarchy of application menu items using "single-root" composite
Also solve composed typing of application menu by using Discriminated Unions of TypeScript, see: https://www.typescriptlang.org/docs/handbook/2/narrowing.html#discriminated-unions

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:16 +03:00
Janne SavolainenandMikko Aspiala 159f2bb9c1 Migrate more application menu items to injectables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:37:59 +03:00
Iku-tursoandJanne Savolainen eba75af764 Implement hierarchy of application menu items using "many-root" composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:37:59 +03:00
Iku-tursoandJanne Savolainen 043afc3ac8 Introduce way to create hierarchical composites from a flat array
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:37:58 +03:00
Iku-tursoandJanne Savolainen 3add4255cf Simplify a test
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:37:58 +03:00
Iku-tursoandJanne Savolainen 3d35ba5c24 Make global override less strict to simplify setup of many unit tests
There's a better solution for this in the horizon, as this overridden thing is better faked than stubbed.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:37:28 +03:00
Iku-tursoandJanne Savolainen 55ad4ffcae Make the di's for unit testing able to auto-register also named exports
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:37:28 +03:00
Iku-tursoandJanne Savolainen a811b0948f Introduce way to type narrow a string property
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:37:14 +03:00
Iku-tursoandJanne Savolainen cf9bf23ac5 Extract menu item for quitting application as injectable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:37:14 +03:00