Iku-turso and Janne Savolainen
7ca54d8f07
chore: Introduce utility function for "pattern matching" using regex
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-05-10 09:39:01 +03:00
Iku-turso
1b30b50a7d
chore: Try if CI works with an alternate way of specifying npm version
...
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-05-04 14:23:22 +02:00
Iku-turso and Gabriel
6f4fb39936
chore: Revert non-working way to specify npm version in ci
...
This reverts commit 1232445e0agaccettola@mirantis.com >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-05-04 14:23:22 +02:00
Iku-turso
51f75cc9e0
chore: Make ci "npm ci" using correct version of NPM
...
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-05-04 14:23:22 +02:00
Iku-turso
eb297193aa
chore: Make ci "npm install" using correct version of NPM
...
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-05-04 14:23:22 +02:00
Iku-turso and Janne Savolainen
0fe92fb54a
chore: Update package-lock
...
There's supposedly something between devs causing volatility in the
package-lock. Needs some investigation.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-05-04 14:23:22 +02:00
Iku-turso and Gabriel
fa840611a1
chore: Make script "all:install" use the fixed version of npm
...
Co-authored-by: Gabriel <gaccettola@mirantis.com >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-05-04 14:23:22 +02:00
Iku-turso and Gabriel
0003c10dbb
chore: Enforce a specific version of NPM to make package-locks not vary
...
Co-authored-by: Gabriel <gaccettola@mirantis.com >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-05-04 14:23:22 +02:00
Iku-turso and Gabriel
f5cb1c207c
chore: Add npm-script to nuke and reinstall dependencies
...
Co-authored-by: Gabriel <gaccettola@mirantis.com >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-05-04 14:23:22 +02:00
Iku-turso
690dd2e476
chore: Remove some unused dependencies
...
This might even remove a cycle in lerna task graph which can be seen as
warning, sometimes (reason unknown).
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-05-04 14:22:04 +02:00
Iku-turso and Janne Savolainen
9c3160a989
chore: Bump ogre-tools
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-05-03 09:31:24 +03:00
Iku-turso and Janne Savolainen
e81affe0e3
chore: Make infrastructure for webpack cleanable
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-05-03 09:31:24 +03:00
Iku-turso and Janne Savolainen
79db1fed26
chore: Consolidate build scripts to the new shared script
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2023-05-03 09:31:24 +03:00
Iku-turso and Janne Savolainen
98fe1a38bf
feat: Introduce reusable script to build using webpack
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2023-05-03 09:31:24 +03:00
Iku-turso and Janne Savolainen
9a4b02becb
chore: Consolidate infrastructure of webpack to ts to make it scriptable
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2023-05-03 09:31:24 +03:00
Iku-turso
db9a3675e1
chore: Extract an injectionToken
...
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-04-25 17:38:02 -04:00
Iku-turso
e5f5151b3c
Update package lock ( #7288 )
...
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-03-06 14:45:24 +02:00
Iku-turso
d3c9c6b5f6
Fix failing unit tests about overriding too late ( #7287 )
...
The fix was to defer injection. The error was made possible in master by git-merging a PR which was
falsely green.
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-03-06 14:45:12 +02:00
Iku-turso and Janne Savolainen
c6799e1478
White-listing of telemetry params ( #7262 )
...
* Drop support for adding telemetry by tagging
This was not used, and would make development of future feature more difficult.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce white-listing for params of telemetry
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Fix linting
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make misconfigured telemetry for function parameters log the error, and not blow up fatally
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
---------
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2023-03-06 13:14:27 +02:00
Iku-turso
75aee7e4fd
Make preferences from extensions using tabs "application" and "telemetry" appear as last ( #6674 )
2022-11-30 11:37:18 +02:00
Iku-turso
1e0094bd8e
Fix extensions using "application" as magic string for preference tab ( #6666 )
...
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2022-11-29 12:13:09 -05:00
Iku-turso and Janne Savolainen
bf11a482c2
Preserve preference URLs ( #6501 )
...
* Add line breaks for readability of a long warning message
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Preserve URLs leading to extension preferences
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Tweak variable name for readability
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2022-11-09 09:09:36 +02:00
Iku-turso and Janne Savolainen
646e953d47
Bump ogre-tools and adapt to breaking changes ( #6481 )
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2022-10-27 12:06:03 +03:00
Iku-turso and Janne Savolainen
37eb236948
Refactor and transform "Application update", "Preferences" and "Application menu" into Features ( #6437 )
...
* Move some code for application update to feature directory
The rest of the code could not be moved yet because of work-in-progress refactorings for OCP compliance.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce helper to get a global override for a function-injectable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract global override-files from bloated getDiForUnitTesting
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Move some more code for application update to feature directory
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce competition for top bar items to achieve OCP-compliance
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract top menu item for opening context menu using the new competition
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract top menu item for navigating to home as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract top menu item for navigating to back as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract top menu item for navigating to forward as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract top menu item for application update as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Format code to make ongoing refactoring a bit easier
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Add missing unit tests for top bar extendability using extension API
This makes ongoing refactoring easier.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Replace implementation for old top-bar items for losing competition
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract top menu item for window controls as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce reusable component for spacing between other components
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce helper component to render list of React elements
Features:
- Placeholder for empty list
- Separators between items
- No boilerplate for "key" prop in React
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix double-clicking and dragging of window from top bar
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix stuff broken in rebase
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Update snapshots after rebase
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make fake time have a default value for "now"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Migrate some application menu items to injectables
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Consolidate separators of application menu in single file
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Remove duplication from separators in application menu
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract some operation system actions from application menu as injectables
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract menu item for quitting application as injectable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce way to type narrow a string property
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make the di's for unit testing able to auto-register also named exports
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make global override less strict to simplify setup of many unit tests
There's a better solution for this in the horizon, as this overridden thing is better faked than stubbed.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify a test
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce way to create hierarchical composites from a flat array
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Implement hierarchy of application menu items using "many-root" composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Migrate more application menu items to injectables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Simplify hierarchy of application menu items using "single-root" composite
Also solve composed typing of application menu by using Discriminated Unions of TypeScript, see: https://www.typescriptlang.org/docs/handbook/2/narrowing.html#discriminated-unions
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update snapshot
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify creation of composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make composite able to have custom handler for missing parent ids
This will be useful next for application menu items, where a missing parent id cannot be fatal.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Defend against self-referencing composites
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Reintroduce non-fatal handling of orphan application menu items
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make faked, yet weak, typing a bit stronger
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify getting of composite paths
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make registrator for application menu items support all known scenarios
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Add logging for unrecognizable application menu item types
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Rename id of menu item to keep it discoverable by existing extensions
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Consolidate code to check for updates closer to feature
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce reusable horizontal line
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for preferences as a Feature
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for terminal preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for editor preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for proxy preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for telemetry preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for application preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Move code related to helm chart preferences under related Feature in preparation for competition
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for kubernetes preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using competition for application preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using competition for editor preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using competition for kubernetes preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using competition for proxy preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add missing observer to make sure component updates
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using competition for telemetry preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using competition for terminal preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak UI for preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak more UI of preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Revert "Introduce reusable horizontal line"
This reverts commit 4d8c147fe0f1a14bd884f73cf345e7d3a28b954a.
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce utility to find exactly one item from array
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for preferences navigation
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Move code under a Feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove usage of old code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove dead code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add extensions tab group to preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce way to find out if composite has a descendant
This will serve eg. hiding of empty preference tab groups.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make tab groups and tabs in preferences not render when there is no content
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Remove code made redundant with hiding of preference tabs without content
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Tweak UI for preference navigation tab groups
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce test helper to abstract discovery of HTML elements
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kill dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate discovery of HTML elements in some tests
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Adapt application builder to changes in preference navigation
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Adapt test setup to changes in preference navigation
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove uninteresting technical tests that are covered by behavioural ones
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate discovery of HTML elements in a test
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove test ID made redundant by consolidating discovery of HTML elements
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove duplication from preference pages
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix import
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make queries in element discovery return matching attribute values for easier testing
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make element discovery able to do nested discovery
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make element discovery able to discover without value for attribute
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Implement registrator for preference items
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make styling less brittle by not relying on static HTML-element structures with CSS-rules
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Add todo
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Remove "group" from preference types, as it is exact replica of "item"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Update snapshots
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Replace usages of react-component factory with actual components for simplicity
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Start considering application preferences as default tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate naming
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make sense in horizontal lines
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Clean public interface of a normalize composite
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate name of function
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate directory structure of composite
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Move utility functions to common
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Rename a preference item type to better communicate intent in UI
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Move shared UI component to more common place
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate sizing of horizontal line to t-shirts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Move application update related preferences under application update feature
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make winner of competition to use original route for preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make HTML element discovery require less parameters
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract "composable-responsibilities" for Discriminable, Labelable, Orderable, and Showable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Update snapshot
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Remove dead code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Move code under a feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate navigating to preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Move code under a feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Relocate code under a sub-feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add TODO
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove dead code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix merge conflicts
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update snapshots after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix import path after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove duplication from exhaustiveness checks for discriminating unions
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add TODO
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update link to a more recent article
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify static Showability of a PreferenceItem
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Move general function to general directory
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract responsibility of "separability"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make separator in Map-component know left and right item
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Remove additional separators when separated items are not shown for having no content
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix lint error
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Adapt integration test to recent changes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Adapt more integration tests to recent changes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make composite not care about in formatting of ids
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Adapt application builder and tests to array-like paths over string-like paths
Array-like paths do not have weakness for special characters as part of id, such as ".".
Also note: the error messaging for clicking of application menu in application builder is a bit worse now I think, but the simplification of the test code is worth it in this case IMHO.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make composite not care about formatting of ids
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Adapt application builder and tests to array-like paths over string-like paths
Array-like paths do not have weakness for special characters as part of id, such as ".".
Also note: the error messaging for clicking of application menu in application builder is a bit worse now I think, but the simplification of the test code is worth it in this case IMHO.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Consolidate output of get-composite-path to match find-composite's input
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make global overrides for functions log args of the call for devability
Also make the thrown error suggest how to fix the problem.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make attempts to log error throw in unit tests
Errors cannot be allowed to happen without a unit test explicitly causing it. Errors cannot be allowed to happen without author of unit test knowing it.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make composite not know about how children are transformed
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Remove some duplication from tests of composite
Also make the thrown error suggest how to fix the problem.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make composite unit test an unrealistic test scenario about undefined ids
Also make the thrown error suggest how to fix the problem.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Kill dead code
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify unit tests for composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Consolidate tests to now point-free composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify "Showable"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make non-shown application menu items not break composite structure
This was made apparent by adding related unit tests for all known environments.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify usages of Orderable and Showable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract being maybe Showable as explicit composable responsibility
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make more showables maybe showable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Consolidate logic for application menu for Windows to be based on composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Start using named export for composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Rename type for accuracy
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Remove unnecessary type and value
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make composable responsibilities readonly to nudge towards immutability
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Remove a bit of duplication to create TS-constants
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make a comment and test name make more sense
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify fallthrough in a switch/case
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Replace inline styles with proper CSS
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Switch to correct type to indicate "object which might not contain a property"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify overriding of platform in a unit test
Also make typing of platforms more strict, and remove some magic strings.
Also add a TODO for further OCP-ification.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Consolidate some "maybe-types" and arguments using them
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Update snapshots
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
2022-10-26 11:16:23 -04:00
fc3512daf2
Introduce a centralised way to emit telemetry from calls of injectable functions ( #6164 )
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Co-authored-by: Juho Heikka <juho.heikka@gmail.com >
2022-09-02 09:33:22 -04:00
Iku-turso and Janne Savolainen
3e02229920
Make injectables in new "features"-directory auto register to make ADR in #6015 possible ( #6034 )
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2022-08-16 15:56:11 +03:00
Iku-turso and Janne Savolainen
299922c8a7
Rename old directory for behaviours as "features" to better communicate new intent with new directory structure to organize code and tests around features instead of technicalities ( #6033 )
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
2022-08-16 15:09:08 +03:00
Iku-turso and Janne Savolainen
730db204f7
Initialize a cli-tool to maintain Architectural Decision Records and create initial ADR ( #5712 )
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-08-10 14:36:26 +03:00
Iku-turso and Janne Savolainen
71427da02d
Helper to resolve proxy from URL in any environment, or using extension-API ( #5690 )
...
* Permit modular directory structures for behaviours in spirit of "Screaming Architecture"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Implement env-agnostic helper to resolve proxy from URL
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Implement way to resolve a proxy, that is not reliant on existing windows
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Restore reliancy on existing windows for resolving proxy for fears of Electron events misbehaving because of a temp-window used in case no windows are open
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make resolving a proxy throw if no browser window is available
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract minimal abstraction for specifically logging error instead of also warn, info, etc.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make decorator for error logging not create orphan promise for easier controllability
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Add error logging to resolving of proxy
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Expose resolving of proxy in extension-API
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Add missing general override
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Add test to add documentation
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Disperse implementation of resolve-proxy back to conventional directory structure instead of an experimental one
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Revert "Permit modular directory structures for behaviours in spirit of "Screaming Architecture""
This reverts commit 75e1231b0e61b74d030d12365352226e7f1ce500.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Rename a helper for less ambiguity
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Add tsdoc for "resolveSystemProxy" exposed in Extension-API
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2022-06-22 16:09:24 +03:00
Iku-turso and Janne Savolainen
55d8e0e06c
Introduce a collection of behavioural unit tests for navigation ( #5085 )
...
This reverts commit ecd881c25df219b511d7efd43dac59e748b21cc7.
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
2022-04-12 07:39:46 +03:00
Iku-turso and Janne Savolainen
a277cfcf02
Technical requirements for behavioural unit tests ( #5084 )
...
* Implement a lot of technical requirements for behavioural unit tests
Note: the crux of this was to make routing env-agnostic, and not based on URLs as magic strings, but instead something type-enforced.
Note: extension-based routes comply to same exact interface by "late-registering" their routes when installed. Routes are just injectables.
Note: another chunk of global shared state is no more.
Note: a lot of explicit side effects have been cornered to injectables.
Note: a lot of stuff has become reactive as part if this.
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make a directory commonly available
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Require id for <Select /> to prevent non-deterministic renders
This was caused by global state in a 3rd party lib: "react-select".
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Specify id for all <Select /> to satisfy previous commit
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Prevent explicit side effect in component by using existing dependency instead
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract instantiation of "conf" as injectables for causing side effects
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce a legacy-helper to make gradual refactoring of inheritors of Singleton easier
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make legacy unit tests for hotbar green and more simple by using the new legacy helper
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Temporarily kludge all unit tests green with a disclaimer about allowing side-effects
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Remove kludge in previous commit by explicitly permitting specific side effects where old unit tests require it
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Prevent old unit test with side effects from accessing file system
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Migrate to actual typing for di.permitSideEffects
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Prevent unit tests from failing because of non-standard method of HTML-element not present in js-dom
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Adapt integration tests to recent changes
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Fix code style
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Fix artifact from bad rebase
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Add a deprecation from a review comment
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Remove change that is not required
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove redundant comment
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix code style
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove redundant file
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix bad merge
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Improve variable name
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Tweak logger interface to be more descriptive
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make injecting legacy singleton always provide new instance
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove conditional typing when not needed
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Improve naming of variable
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove unnecessary code style changes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove flag for causing side effects from too broad scope
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Override side-effects in unit test using injectable instead of monkey patching
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Flag some side-effects and add general overrides
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Fix unit tests in CI by removing explicit side-effect
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Remove explicit side-effect from getting default shell
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce abstraction for getting absolute paths
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using abstraction for getting absolute path to control explicit side effect
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce abstraction for joining paths
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using abstraction for joining paths to control explicit side effect
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix fake implementation for join paths
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix test after removing explicit side effect
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove explicit side effects from kubeconfig-syncs
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix arguments after removing explicit side effect
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make registrators not async for not being needed anymore
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make generalCatalogEntities non-observable, as there is no requirement
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Remove redundant code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify logic for registering general catalog entity sources
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add TODO
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Replace function for getting application menu items with reactive solution
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix typo in interface name
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove global shared state usages of hot bar store
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove redundant enum
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
2022-03-31 16:57:05 +03:00
Iku-turso
5e429d2b93
Yarn scripts for quality of life in development ( #5087 )
2022-03-28 09:09:30 -04:00
Iku-turso
ab4780f67c
Deprecate some undesirables ( #5086 )
2022-03-23 16:25:10 -04:00
Iku-turso
6b28f9e9c3
Bump injectable to 5.1.2 ( #5010 )
2022-03-17 08:15:21 -04:00
Iku-turso
0b321f7144
Merge pull request #4653 from lensapp/eliminate-gst-from-app-paths
...
Eliminate Global Shared State from app paths and relatives
2022-01-17 19:24:15 +02:00
Iku-turso and Janne Savolainen
d89609415b
Kludge a timing issue until root cause of shared global state is fixed
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2022-01-07 12:10:04 +02:00
Iku-turso and Janne Savolainen
f089d5c9e6
Add missing todo
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
2022-01-07 12:10:04 +02:00
Iku-turso and Janne Savolainen
f3d45ea78b
Fix hangup on application start by auto-registering more injectables
...
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
2021-12-09 14:35:29 +02:00
Mikko Aspiala and Janne Savolainen
2e5e549957
Update version of injectable for disambiguous typing
...
Signed-off-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
2021-11-26 07:44:27 +02:00
Iku-tursoandJanne Savolainen
