Commit Graph
2641 Commits
Author SHA1 Message Date
Janne SavolainenandMikko Aspiala 82e268eff3 Move another utility function under directory
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:49:47 +03:00
Janne SavolainenandMikko Aspiala e3ac29cc43 Move utility function under directory
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:49:47 +03:00
Iku-tursoandJanne Savolainen f23ee9c3ce Make downloading of update and what follows more deliberate as orphan promise
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:49:46 +03:00
Iku-tursoandJanne Savolainen 2cd18c7245 Introduce a way to make intentional orphan promises uniform, controllable and deliberate
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:49:46 +03:00
Janne SavolainenandMikko Aspiala ebda9424bb Serialize messages in channels to make IPC not blow up
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:49:46 +03:00
Janne SavolainenandMikko Aspiala c287279949 Make typing of higher order function for error suppression not lie
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:49:46 +03:00
Iku-tursoandJanne Savolainen f39c7aab14 Make a primitive argument an object for readability
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:49:46 +03:00
Iku-tursoandJanne Savolainen 877fa72046 Make different MessageChannels not require explicit "extends JsonObject"
Note: Non-escaped lint breaks type here for forcing interface over type. Reasonable effort brought no understanding for what is the relevant difference between the two.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:49:46 +03:00
Iku-tursoandJanne Savolainen d473551724 Require requests and responses for RequestChannels be JsonValues for serialization
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:49:46 +03:00
Iku-tursoandJanne Savolainen 8432131b1e Require messages for MessageChannels be JsonValues for serialization
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:49:45 +03:00
Janne SavolainenandMikko Aspiala 5f612b774a Tweak timing of sentry setup
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:49:45 +03:00
Janne SavolainenandMikko Aspiala ba9cb134fb Remove unused variable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:49:45 +03:00
Janne Savolainen 1e80cf0b12 Tweak typing of request channel listeners to get rid of unexpected undefined
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:49:45 +03:00
Janne Savolainen 5f8aaac6a6 Revert "Implement requesting from renderer in main"
This reverts commit d3e7899d7900516f3dbfacdb317a453202318305.

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:49:45 +03:00
Janne Savolainen 2427ee13e6 Implement requesting from renderer in main
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:49:45 +03:00
Janne Savolainen a3bc676bf7 Introduce tests for requesting from channel in renderer
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:49:45 +03:00
Iku-tursoandJanne Savolainen fdef6973e3 Separate concept of message and request channels
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:49:43 +03:00
Iku-tursoandJanne Savolainen c01e935422 Implement initial values for sync-boxes
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:44 +03:00
Janne SavolainenandMikko Aspiala 38721f10c6 Remove duplication for disposers
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:44 +03:00
Janne Savolainen eb03ce454c Make dependencies readonly
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:44 +03:00
Janne SavolainenandMikko Aspiala 288b7da1e9 Make code for asserting a promise more strict
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:43 +03:00
Janne Savolainen ec0d2c735f Revert not required changes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:43 +03:00
Janne Savolainen 13c5815c3f Mark injectable causing side effects
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:43 +03:00
Janne Savolainen f1e77070dc Make overridden version of application exactly the one required by unit test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:43 +03:00
Janne Savolainen d18cf3e49e Make higher order function for logging errors support asynchronous rejecting with non error instance
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:43 +03:00
Janne SavolainenandMikko Aspiala 0d37d41170 Relocate some explicit error handlings to proper level of abstraction
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:43 +03:00
Janne SavolainenandMikko Aspiala 93dea5f992 Introduce higher order function for suppressing errors
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:43 +03:00
Janne SavolainenandMikko Aspiala e83c0ff4b6 Tweak test name
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:42 +03:00
Janne SavolainenandMikko Aspiala 66003f1e2c Export type for error logging
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:42 +03:00
Iku-tursoandJanne Savolainen 79f6ed64c7 Introduce higher order function to log errors in decorated functions
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:42 +03:00
Iku-tursoandJanne Savolainen 50edabbd9d Make a channel have default type for sent and returned message
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:42 +03:00
Iku-tursoandJanne Savolainen d5feeade86 Make setting of initial state for sync boxes not trigger irrelevant messaging to main
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:42 +03:00
Iku-tursoandJanne Savolainen ae1b399b62 Simplify code for asking of boolean value from user
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:42 +03:00
Iku-tursoandJanne Savolainen b53fb19818 Make asking of boolean value from user not require explicit ID for question
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:42 +03:00
Iku-tursoandJanne Savolainen 0109968cda Introduce dependency to get random IDs
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:41 +03:00
Iku-tursoandJanne Savolainen a088d08edb Enhance name of behaviour
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:41 +03:00
Iku-tursoandJanne Savolainen f3a790e3f1 Make unit test more strict
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:41 +03:00
Iku-tursoandJanne Savolainen 2b568be416 Improve name of behaviour
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:41 +03:00
Iku-tursoandJanne Savolainen 386b6cdac6 Add todo for cleaning unacceptable code encountered
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:41 +03:00
Iku-tursoandJanne Savolainen 3dcbf34a38 Simplify more and more naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:41 +03:00
Iku-tursoandJanne Savolainen ca1e841429 Simplify even more naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:41 +03:00
Iku-tursoandJanne Savolainen 271cec3217 Simplify more naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:41 +03:00
Iku-tursoandJanne Savolainen 4ae3a30c61 Simplify naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-06-03 07:48:40 +03:00
Janne Savolainen 5a1f5bde75 Make Animate deterministic in unit tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:40 +03:00
Janne Savolainen 8db922edd1 Fix code style
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:40 +03:00
Janne Savolainen 15e6049934 Remove redundant overrides
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:40 +03:00
Janne Savolainen 25bcd18131 Improve name of test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:40 +03:00
Janne Savolainen 67443c0b3b Simplify test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:40 +03:00
Janne Savolainen 6ad6887d3b Remove unimplemented scenario from test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:40 +03:00
Janne Savolainen e6266f7a99 Add TODO
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-06-03 07:48:39 +03:00