Janne Savolainen
|
90e7677f36
|
Rename callback in ApplicationBuilder for accuracy
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:15 +03:00 |
|
Janne Savolainen
|
34e504b65b
|
Prevent restarting a startableStoppable when already being started
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:15 +03:00 |
|
Janne Savolainen
|
43598914ee
|
Remove usage of extension for injectable for being YAGNI
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:15 +03:00 |
|
Janne Savolainen
|
d90b143642
|
Rename injectables for accuracy
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:15 +03:00 |
|
Janne Savolainen
|
b703b43745
|
Consolidate LensProxy related stuff to directory
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:14 +03:00 |
|
Janne Savolainen
|
c2ffdc27b9
|
Rename injectable for brevity
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:14 +03:00 |
|
Janne Savolainen
|
a1df4b6317
|
Tweak comment
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:14 +03:00 |
|
Janne Savolainen
|
8f27110930
|
Tweak name of the splash window for loading to avoid confusion with similarly named phenomenon
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:14 +03:00 |
|
Janne Savolainen
|
37e600cba9
|
Tweak name of timeslot to make it more apparent that new content for application load can be added
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:14 +03:00 |
|
Janne Savolainen
|
12839c7784
|
Extract injectable with side-effect for exact overriding
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:14 +03:00 |
|
Janne Savolainen
|
ff87f627aa
|
Tweak types
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:13 +03:00 |
|
Janne Savolainen
|
b179e0f6a9
|
Revert code-style changes
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:13 +03:00 |
|
Janne Savolainen
|
07f01d52a5
|
Tweak naming of runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:13 +03:00 |
|
Janne Savolainen
|
0f067da6f4
|
Tweak typing
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:13 +03:00 |
|
Janne Savolainen
|
96b5771b08
|
Extract responsibility to injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:13 +03:00 |
|
Janne Savolainen
|
678043e34e
|
Flag injectable causing side effects
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:13 +03:00 |
|
Janne Savolainen
|
3c7b2c9013
|
Extract responsibility of setting dependencies to own injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:13 +03:00 |
|
Janne Savolainen
|
88fe9b1b75
|
Remove global state
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:12 +03:00 |
|
Janne Savolainen
|
fc04a4e17f
|
Add empty mocks comply to lint
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:12 +03:00 |
|
Janne Savolainen
|
767eb75c2b
|
Kill dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:12 +03:00 |
|
Janne Savolainen
|
32a128d44b
|
Simplify naming
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:12 +03:00 |
|
Janne Savolainen
|
1810a330cf
|
Switch to using dependency over using explicit side-effect
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:12 +03:00 |
|
Janne Savolainen
|
82336d7a12
|
Remove code-style changes that are not welcome
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:12 +03:00 |
|
Janne Savolainen
|
5b65a93849
|
Fix code style
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:11 +03:00 |
|
Janne Savolainen
|
1867d22fc9
|
Update yarn.lock after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:11 +03:00 |
|
Janne Savolainen
|
32bc853279
|
Introduce reactive way to get theme from operating system
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:11 +03:00 |
|
Janne Savolainen
|
c7dba52cd0
|
Make startable stoppable support async starting
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:11 +03:00 |
|
Janne Savolainen
|
952ff1deb9
|
Make script for running unit tests support targeting
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:11 +03:00 |
|
Janne Savolainen
|
16b91773ee
|
Extract helpers for testing promises to test-utils
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:11 +03:00 |
|
Janne Savolainen
|
395ce7ab49
|
Flag injectable causing side-effect
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:10 +03:00 |
|
Janne Savolainen
|
551736ac2a
|
Simplify directory structures for runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:10 +03:00 |
|
Janne Savolainen
|
55d1471c10
|
Consolidate code for application window
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:28:08 +03:00 |
|
Janne Savolainen
|
5ac9b2aa87
|
Extract responsibilities of WindowManager as injectables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:27:17 +03:00 |
|
Janne Savolainen
|
5842db2cc3
|
Make quit of hidden Lens not blow up
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:36 +03:00 |
|
Janne Savolainen
|
ec279d4f5c
|
Make it possible to not stop something that was never started
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:36 +03:00 |
|
Janne Savolainen
|
d6a0880df0
|
Tweak timeslot of a runnable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:36 +03:00 |
|
Janne Savolainen
|
5f51c90ca3
|
Fix missing injectable postfix in file name
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:36 +03:00 |
|
Janne Savolainen
|
b3dab6b781
|
Fix application quit by calling Electron's event.preventDefault in a very specific way and preventing async
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:36 +03:00 |
|
Janne Savolainen
|
98cecaa91c
|
Kill dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:35 +03:00 |
|
Janne Savolainen
|
25a48f3d7d
|
Make runnables for before application is ready synchronous as this is technical limitation of Electron
See: https://github.com/electron/electron/issues/21370
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:35 +03:00 |
|
Janne Savolainen
|
d4b2ff992a
|
Introduce a way to run many synchronous runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:35 +03:00 |
|
Janne Savolainen
|
497c5258e6
|
Make splash screen not blow up by providing compile-time environment variables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:35 +03:00 |
|
Janne Savolainen
|
0d41eabb64
|
Extract tray icon path as injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:35 +03:00 |
|
Janne Savolainen
|
76e6718874
|
Tweak timing of runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:35 +03:00 |
|
Janne Savolainen
|
579dfd2d0b
|
Deprecate another var with injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:35 +03:00 |
|
Janne Savolainen
|
d93080b4e5
|
Consolidate to use injectable instead of var for static file directory
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:34 +03:00 |
|
Janne Savolainen
|
90c52a98b2
|
Remove redundant import
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:34 +03:00 |
|
Janne Savolainen
|
7f0eb07cc5
|
Ensure that LensProxy is setupped before starting the main window
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:34 +03:00 |
|
Janne Savolainen
|
00a5e54ce8
|
Fix setupping of sentry after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:34 +03:00 |
|
Janne Savolainen
|
c6c128e890
|
Kludge around test setup which is difficult because of circular dependencies
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
|
2022-05-11 08:25:34 +03:00 |
|