Commit Graph
7 Commits
Author SHA1 Message Date
Hung-Han (Henry) Chen a0296d606d Remove try...catch block
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
2021-07-12 14:39:35 +03:00
Hung-Han (Henry) Chen ec8c3bc26d Remove try-catch for Sentry.init (exception should be caught by lens-ide tests, not in runtime), remove isValidSentryDsn/isValidSentryDsn(), use sentryDsn string to determine if preference UI should show
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
2021-07-12 12:43:14 +03:00
Hung-Han (Henry) Chen ccabff5e4c Improve log
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
2021-07-09 14:31:54 +03:00
Hung-Han (Henry) Chen 8af3f2cd5b SentryInit is sync now, and remove warning comments
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
2021-07-09 14:23:48 +03:00
Hung-Han (Henry) Chen e815461cb4 Move SentryInit before logger.log to avoid winston exceptions
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
2021-07-09 14:22:38 +03:00
Hung-Han (Henry) Chen 31745b38da Remove sentryIsInitialized (not in used), remove requireSentry hack as we already enable node integration in renderer process, this https://docs.sentry.io/platforms/javascript/guides/electron/#webpack-configuration mod.require shpuld be avaible in renderer; add try..catch block around serStore.getInstance()?.allowErrorReporting to set allowErrorReporting default to false. Make SentryInit() sync
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
2021-07-09 14:21:00 +03:00
Hung-Han (Henry) Chen b68288e8e4 Adding back isValidSentryDsn and sentryDsnIsValid, and use sentryDsnIsValid to determine the UI should be shown, regression introduced in https://github.com/lensapp/lens/pull/3315
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
2021-07-09 14:17:10 +03:00