hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity
2,399 Commits 268 Branches 11 Tags 985 MiB
bfd08578ae
Commit Graph

1532 Commits

Author SHA1 Message Date
Janne Savolainen
bfd08578ae
Simplify logic for registering general catalog entity sources 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:36 +03:00
Iku-turso
0e92d1d1f8
Remove redundant code 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:36 +03:00
Iku-turso
0bf819a469
Make generalCatalogEntities non-observable, as there is no requirement 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:36 +03:00
Janne Savolainen
1c31e9cb30
Make registrators not async for not being needed anymore 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:35 +03:00
Janne Savolainen
22d45ab6fa
Fix arguments after removing explicit side effect 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:35 +03:00
Janne Savolainen
4efbc1de3e
Remove explicit side effects from kubeconfig-syncs 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:35 +03:00
Janne Savolainen
83cb571e5f
Fix test after removing explicit side effect 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:35 +03:00
Janne Savolainen
6a9f77757f
Fix fake implementation for join paths 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:35 +03:00
Janne Savolainen
af3325e816
Switch to using abstraction for joining paths to control explicit side effect 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:34 +03:00
Janne Savolainen
c5b14c48d8
Introduce abstraction for joining paths 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:34 +03:00
Janne Savolainen
911481ea0f
Switch to using abstraction for getting absolute path to control explicit side effect 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:34 +03:00
Janne Savolainen
5ca3082572
Introduce abstraction for getting absolute paths 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:34 +03:00
Janne Savolainen
21f815bdea
Remove explicit side-effect from getting default shell 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:34 +03:00
Iku-turso
e2889c226b
Fix unit tests in CI by removing explicit side-effect 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:34 +03:00
Iku-turso
2e503b1698
Flag some side-effects and add general overrides 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:33 +03:00
Iku-turso
20805e27ff
Override side-effects in unit test using injectable instead of monkey patching 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:33 +03:00
Janne Savolainen
504557fc62
Remove flag for causing side effects from too broad scope 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:33 +03:00
Janne Savolainen
5113729e87
Remove unnecessary code style changes 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:33 +03:00
Janne Savolainen
dd11bcd67e
Improve naming of variable 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:33 +03:00
Janne Savolainen
e3678935bd
Remove conditional typing when not needed 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:32 +03:00
Janne Savolainen
76101023df
Make injecting legacy singleton always provide new instance 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:32 +03:00
Janne Savolainen
39795d8f35
Tweak logger interface to be more descriptive 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:32 +03:00
Iku-turso
e3c54705ac
Improve variable name 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:32 +03:00
Iku-turso
acf04d2604
Fix bad merge 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:32 +03:00
Janne Savolainen
3acb0e53c2
Remove redundant file 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:32 +03:00
Janne Savolainen
e8f521ef4e
Fix code style 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:31 +03:00
Janne Savolainen
010b3a18bd
Remove redundant comment 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:31 +03:00
Janne Savolainen
0582b62a11
Remove change that is not required 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:31 +03:00
Iku-turso
7b0ac796d2
Add a deprecation from a review comment 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:31 +03:00
Iku-turso
6ed5244421
Fix artifact from bad rebase 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:31 +03:00
Iku-turso
480bad870f
Fix code style 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:30 +03:00
Iku-turso
836c2c1dbf
Prevent unit tests from failing because of non-standard method of HTML-element not present in js-dom 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:30 +03:00
Iku-turso
9a5a210ed3
Migrate to actual typing for di.permitSideEffects 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:30 +03:00
Iku-turso
906f23214e
Prevent old unit test with side effects from accessing file system 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:30 +03:00
Iku-turso
03cd6aac87
Remove kludge in previous commit by explicitly permitting specific side effects where old unit tests require it 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:29 +03:00
Iku-turso
333ef65441
Temporarily kludge all unit tests green with a disclaimer about allowing side-effects 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:29 +03:00
Iku-turso
eb756f4da4
Make legacy unit tests for hotbar green and more simple by using the new legacy helper 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:29 +03:00
Iku-turso
b935dbca78
Introduce a legacy-helper to make gradual refactoring of inheritors of Singleton easier 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:29 +03:00
Iku-turso
d8fdd12a3c
Extract instantiation of "conf" as injectables for causing side effects 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:29 +03:00
Iku-turso
1bf61b6870
Prevent explicit side effect in component by using existing dependency instead 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:28 +03:00
Iku-turso
ec33125373
Specify id for all <Select /> to satisfy previous commit 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:28 +03:00
Iku-turso
9c024b98d3
Require id for <Select /> to prevent non-deterministic renders 
This was caused by global state in a 3rd party lib: "react-select".

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:28 +03:00
Iku-turso
b947568b14
Make a directory commonly available 
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-03-31 15:13:28 +03:00
Janne Savolainen
5c8ca2c038
Implement a lot of technical requirements for behavioural unit tests 
Note: the crux of this was to make routing env-agnostic, and not based on URLs as magic strings, but instead something type-enforced.

Note: extension-based routes comply to same exact interface by "late-registering" their routes when installed. Routes are just injectables.

Note: another chunk of global shared state is no more.

Note: a lot of explicit side effects have been cornered to injectables.

Note: a lot of stuff has become reactive as part if this.

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-03-31 15:13:26 +03:00
Sebastian Malton
086604630a
Add links for ingresses (#4630) 
* Add links for ingresses

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Add back the arrow service

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Only display link if host is defined

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Resolve PR comments

- Fix crash in IngressDetails

- Make ingress routes scrollable

- Don't display link if the URL contains "*"

- Consolidate rendering of rules to all use the same transform function

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix http(s) formatting and add some tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>
 2022-03-31 07:58:35 -04:00
Sebastian Malton
63fb94589a
Fix CatalogEntity.status sorting in Catalog (#5147) 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
 2022-03-31 07:58:01 -04:00
Alex Andreev
90d4d41936
Set dock tab contrast bg color (#5143) 2022-03-30 10:54:34 -04:00
Alex Andreev
37d8294198
Remove HotbarIcon box-shadow artifacts (#5142) 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
 2022-03-30 15:23:46 +03:00
Sebastian Malton
69f1ecb0b9
Fix exception in KubeStore.watch event buffer handling (#5120) 
* Fix exception in KubeStore.watch event buffer handling

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix type error

Signed-off-by: Sebastian Malton <sebastian@malton.name>
 2022-03-30 07:04:59 -04:00
dependabot[bot]
f0978f02c9
Bump electron-updater from 4.6.1 to 4.6.5 (#5125) 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Malton <sebastian@malton.name>
 2022-03-29 15:20:41 -04:00