Janne Savolainen
d6ca2c2cd7
Allow reactive tray item labels for extensions ( #6036 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-08-16 08:28:07 +03:00
Janne Savolainen
33834e34b7
Optimize getting injectable paths only once for all test suites ( #6013 )
2022-08-11 09:42:52 -04:00
Janne Savolainen
ef12676b89
Update injectable for improved performance ( #6011 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-08-11 09:47:11 +03:00
Janne Savolainen
688ef40e92
Fix incorrect links in workload overview page ( #6002 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-08-08 12:26:48 -04:00
Janne Savolainen
06d780479c
Tweak timing of starting and stopping periodical checking for updates ( #5981 )
2022-08-04 14:21:16 -04:00
Janne Savolainen
04652b4f90
Tweak timing of starting and stopping kubeconfig sync ( #5982 )
2022-08-04 14:12:33 -04:00
Janne Savolainen
83232440dc
Replace individual mocks for withTooltip with global mock ( #5962 )
2022-08-02 10:06:37 -04:00
Janne Savolainen
af4b74d9bd
Open application only if new update is available when using tray to check for updates ( #5948 )
...
* Prevent opening of application if no new updates were downloaded when checking for updates using tray when application window is closed
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix getting initial value of sync box
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak naming of variable
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-07-29 15:55:16 +03:00
Janne Savolainen
d78d009d41
release v6.0.0 ( #5935 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-07-28 14:42:14 +03:00
Janne Savolainen
da1f975ccc
release v6.0.0-alpha.1 ( #5933 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-07-28 10:18:02 +03:00
Janne Savolainen
e682c7de45
Fix editing of kube resource ( #5906 )
2022-07-27 11:44:11 -04:00
Janne Savolainen
a12b94405a
Resolve kube object status texts again on re-render to make it look like it's reactive ( #5875 )
...
* Make tests for kube object status icon more realistic
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Start resolving kube object status texts on each re-render to mimic reactivity
Note: This is done due the current implementation exposed in Extension API expects it to work so. However, this is bad.
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using existing implementation for isDefined
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-07-27 09:21:38 +03:00
Janne Savolainen
bedc440d42
Fix opening of release details ( #5850 )
...
* Make sure release details are updates when opening details
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Relax filtering of resources to prevent crashing when release has installed resources in another namespace
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add Open Closed Principle compliant way to introduce global overrides without modification in getDiForUnitTesting
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Rework helm release details to fix multiple bugs
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove redundant optional chaining
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Simplify code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-07-26 14:57:46 +03:00
Janne Savolainen
f281df1693
Fix installation of helm charts ( #5841 )
...
* Relax validator for installing charts
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak spacing between words in confirmation dialog
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add mocks for monaco editor and virtualized auto sizer to allow components to be rendered in unit tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Improve typing for a function
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove usage of shared global state from a component
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Provide a way to unit test usages of storages
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add way to get current value from select in behavioural unit tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Rework installation of helm charts to get rid of the majority of bugs
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update snapshots
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove technical test for being covered in behaviours
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Split behaviour to smaller pieces
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add tests accidentally removed back
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Mark functions causing side effects
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove behaviour covered by other behaviours
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak naming
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove unused dependency
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-07-20 08:15:27 +03:00
Janne Savolainen
d66e6c23c5
Expose reactive ways to hide items in cluster frame using Extension API - PART 7 ( #5824 )
...
* Kludge "isEnabledForCluster" work again for cluster pages
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kludge "isEnabledForCluster" work again for kube object details
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Expose reactive way to hide kube object detail items in Extension API
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Expose reactive way to hide kube object menu items in Extension API
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Expose reactive way to hide kube object status items in Extension API
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Expose reactive way to hide workload overview detail items in Extension API
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Expose reactive way to disable pages in Extension API
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Expose a way to access active cluster from Extension API
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Deprecate "isEnabledForCluster" in favor of individual enabled or visible properties for each registration
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-07-13 13:47:03 -04:00
Janne Savolainen
ca40c51117
Introduce kludge to make "isEnabledForCluster" work again for cluster pages PART 1 ( #5800 )
...
* Kludge "isEnabledForCluster" work again for cluster pages
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce kludge to make "isEnabledForCluster" work again for cluster page menus PART 2 (#5801 )
* Kludge "isEnabledForCluster" work again for cluster page menus (sidebar items)
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce kludge to make "isEnabledForCluster" work again for kube object status texts PART 3 (#5802 )
* Kludge "isEnabledForCluster" work again for kube object status texts
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kludge "isEnabledForCluster" work again for kube object menu items (#5803 )
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce kludge to make "isEnabledForCluster" work again for workload overview details PART 5 (#5804 )
* Kludge "isEnabledForCluster" work again for cluster page menus (sidebar items)
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kludge "isEnabledForCluster" work again for kube object status texts
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kludge "isEnabledForCluster" work again for kube object menu items
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kludge "isEnabledForCluster" work again for workload overview details
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kludge "isEnabledForCluster" work again for kube object details (#5805 )
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-07-13 08:36:51 +03:00
Janne Savolainen
63bd783803
Add global override for component observing current time for causing … ( #5814 )
2022-07-08 12:54:23 -04:00
Janne Savolainen
c53aa77775
Update snapshots after merging something ( #5815 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-07-08 15:20:10 +03:00
Janne Savolainen
b16a419287
Fix menu actions not opening in multiple places ( #5799 )
2022-07-07 09:23:24 -04:00
Janne Savolainen
6e5c8e0427
Force update after thirty days since update was downloaded ( #5776 )
2022-07-06 09:48:00 -04:00
Janne Savolainen
eb6cc70143
Expose a way to reactively control visibility of preference tabs and tray menu items through Extension API ( #5789 )
2022-07-06 08:51:59 -04:00
Janne Savolainen
5ac33a6070
Prevent re-downloading update that is already downloaded ( #5781 )
2022-07-06 08:06:59 -04:00
Janne Savolainen
4d99a46dfe
Make application window appear even when its hidden underneath other apps ( #5782 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-07-06 09:44:56 +03:00
Janne Savolainen and Sebastian Malton
667053cdf5
Replace status bar item application update with different tray icon based on status of the update ( #5769 )
...
* Remove the auto-update status bar item for not being needed anymore
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make adding of new tray icons easier by complying to Open Closed Principle
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Start showing different tray icon when checking for updates
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Include placeholder icon for checking for updates
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Simplify code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add first keyframe for downloading spinner
Signed-off-by: Sebastian Malton <sebastian@malton.name >
Co-authored-by: Sebastian Malton <sebastian@malton.name >
2022-07-05 15:44:03 -07:00
Janne Savolainen and Mikko Aspiala
14d5a1c3cc
Split root and cluster frames in smaller pieces ( #5737 )
...
* Make root frame child components comply with open closed principle and include it in the behavioural unit tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make cluster frame child components comply with open closed principle and include it in behavioural unit tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove duplication
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Simplify test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make a component more determistic in unit tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Mock uninterested, non-deterministic third party library in unit tests
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Optimize registration of injectables in unit tests to make tests faster
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update snapshots
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove import time side-effect causing memory leak
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-07-04 09:38:29 -07:00
Janne Savolainen
5f57213179
Fix stuff happening based on timers not being run correctly in unit tests ( #5764 )
...
* Introduce helper for advancing fake time
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce reactive now to kludge around global shared state in library
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Replace all usages of "now" from mobx-utils with our own kludge to get rid of shared global state between unit tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate all usages of advanceTimersByTime to make sure things happening based on timers are run correctly
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix incorrect expect in test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Enable skipped unit test since prerequisites are done
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-07-01 19:40:34 +03:00
Janne Savolainen
5d76dd4fc2
Stop trying to restart catalog sync and updating of application when reloading window ( #5735 )
2022-06-29 08:22:08 -04:00
Janne Savolainen
657119b22b
release v5.6.0-alpha.5 ( #5754 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-29 15:15:15 +03:00
Janne Savolainen
2b9c2ad69e
Re-export types for notifications store to revert accidental breaking… ( #5715 )
...
* Re-export types for notifications store to revert accidental breaking change
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak exports for notifications to provide same API contract
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-27 09:06:02 +03:00
Janne Savolainen
49e0a0286d
release 5.6.0-alpha.4 ( #5701 )
2022-06-23 15:14:26 -04:00
Janne Savolainen
fc770b4b44
Revert accidental breaking change ( #5703 )
2022-06-22 09:48:09 -04:00
Janne Savolainen and Mikko Aspiala
fa23b5cd3f
Fix download percentages not updating in tray ( #5697 )
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-22 15:37:13 +03:00
Janne Savolainen and Mikko Aspiala
f8b008612f
Trivial tweaks accidentally left from other PR ( #5679 )
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
2022-06-20 11:49:59 -04:00
Janne Savolainen
f87f5f245c
Simplify logic for injecting many instances which can reactively change e.g. based on extension being enabled or disabled ( #5662 )
...
* Reorganize stuff to prevent circular dependencies
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Install injectable extension to allow injecting reactively many implementations
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using computedInjectMany over filtering injectMany based on enabled extensions for simplicity
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove await for not being needed
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Sort dependencies alphabetically
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-20 10:19:20 +03:00
Janne Savolainen
d0ed4e46b1
Fix tray bugs ( #5666 )
...
* Make unit tests for tray behave correctly when item is disabled
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make multiple separators in tray originating from same extension not throw up
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-17 16:21:18 +03:00
Janne Savolainen
10ba9ef853
Add behaviour for tray menu items originating from extensions ( #5609 )
2022-06-17 08:07:26 -04:00
Janne Savolainen
2a5b4af344
Fix issue where releases are not reloaded when new release is added externally (e.g. from terminal) ( #5603 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-17 10:26:07 +03:00
Janne Savolainen
d1f5f1cdef
Fix flaky unit test ( #5661 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-17 10:25:01 +03:00
Janne Savolainen
9c420d6f1e
Try solving flaky unit test by switch to use different implementation of setImmediate ( #5655 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-16 09:57:32 -04:00
Janne Savolainen
5c049ecca0
Improved metrics for updating application ( #5607 )
2022-06-16 09:05:00 -04:00
Janne Savolainen
7b0521f3b2
Rename injection token for clarity ( #5636 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-16 08:44:38 -04:00
Janne Savolainen
287c814565
Move phenomenon of renderer out from common by introducing different implementations for environments
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-16 08:44:38 -04:00
Janne Savolainen
fa32aa1b8e
Make jest not crash totally when encountering non handled exception ( #5634 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-15 19:37:22 -04:00
Janne Savolainen and Mikko Aspiala
6451df1f17
Prevent duplicate app windows ( #5533 )
...
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Co-authored-by: Iku-turso <mikko.aspiala@gmail.com >
2022-06-15 16:40:34 -04:00
Janne Savolainen
2eb585e88e
Fix merge conflict with async validators ( #5606 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-13 15:19:37 +03:00
Janne Savolainen and Mikko Aspiala
1393cc303d
Stop using HelmCli from Renderer ( #4861 )
...
* Introduce way for execute file
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make typing of HelmRepo shared
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce way to get Helm environment values
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce function to read YAML file
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for listing active helm repositories in preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make sense in name of injectable
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce helper for opening and selecting values of select
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for activating, deactivating public helm repositories in preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for deactivating helm repository from list of active repositories
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add missing global overrides
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make some tests more deterministic by mocking tooltips
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for activating custom helm repository in preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove old implementation made redundant with competition for preferences of helm repositories
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add success notification for activating custom helm repository
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce way to get single active helm repository
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract responsibilities from god-class and switch to getting helm repositories using competition instead of another god class
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add TODO
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak position of spinner
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Start handling errors when accessing helm repositories
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Handle error about no helm repositories when updating repositories
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove unwarranted function configuration
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add missing global overrides
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove duplication how to acquire binary path for helm
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove redundant comment
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate naming to match Helm's internal
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Relocate file closer to it's relatives
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-13 11:42:53 +03:00
Janne Savolainen and Mikko Aspiala
ef6f4a5bfa
Bump injectable for faster unit tests ( #5587 )
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-06-09 15:12:57 +03:00
b414f9e06d
Introduce way to install update directly from tray. Make application updater unit testable... ( #5433 )
...
* Extract product name as injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make tray items comply with Open Closed Principle
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Replace duplicated overrides with global
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add behaviour for navigating to preferences using tray
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce a tray item for updating application
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak naming
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak more naming
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove redundant indirection
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak more naming
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce injectable for package.json being side-effect
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Relocate file to directory containing feature
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable for limiting side effect
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add missing injection token for implementation of tray item
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove resetting state for update is ready to be installed for being unclear
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kill dead code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make label of tray item reactive
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract updating is enabled to separate injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for tray
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Expand scope of behaviour for updating using tray also contain checking for updates
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kill dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Implement checking of updates from multiple update channels
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Start installing updates automatically when quitting application
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Show application window when checking of updates has happened
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Show notifications and dialog for downloading update
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Implement naive notifications for version updates
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Implement checking of Electron specific updates as responsibility
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Implement downloading of Electron specific updates as responsibility
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce competition for channel abstraction
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove redundant global override
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix typing after enabling strict mode
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce abstraction for a state that is shared between environments
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract states of application update to be usable from all environments
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Handle failing download of update
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make code for window visibility actually work
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate code for sending messages between processes to a window
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Split bloated dependency in smaller pieces
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make state of download progress accessible from all environments
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Rename files for accuracy
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Move channel abstraction to more global directory
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Enhance typing of channels and sync-box
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate channel abstraction types
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update asyncFn to support strict mode
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix snapshot after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add missing global override
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce injection token for channels to allow injecting all of them at once
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add notifications about change in update status
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Rename property for accuracy
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak code style
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make notifications unit testable in behaviours
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add implementation for asking boolean over processes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reorganize responsibilities for checking updates
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reorganize tests for installing update under separate scenarios
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make stuff happening when root frame is rendered unit testable
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce periodical check for updates
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Allow downgrading app versions
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using competition for checking of updates in application menu
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kill dead code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make test less prone to fail for wrong reason
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove redundant boilerplate
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make tests for specific migrations less prone to failing for wrong reason
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Move shared stuff under common
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using single source of truth for selected update channel
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract tests for installing update from different update channels to separate scenario
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add missing global override
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using release channel of installed application version as default value for selected update channel
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate usage of channel abstraction to same implementation
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make Channel abstraction support return values
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix direct calling of runnables
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Synchronize initial values of sync boxes when window starts
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add missing global override
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak message of question from user
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate names of directories
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add TODO
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove unimplemented scenario from test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Simplify test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Improve name of test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove redundant overrides
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix code style
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make Animate deterministic in unit tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Simplify naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify more naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify even more naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify more and more naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Add todo for cleaning unacceptable code encountered
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Improve name of behaviour
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make unit test more strict
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Enhance name of behaviour
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce dependency to get random IDs
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make asking of boolean value from user not require explicit ID for question
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Simplify code for asking of boolean value from user
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make setting of initial state for sync boxes not trigger irrelevant messaging to main
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make a channel have default type for sent and returned message
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce higher order function to log errors in decorated functions
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Export type for error logging
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak test name
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce higher order function for suppressing errors
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Relocate some explicit error handlings to proper level of abstraction
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make higher order function for logging errors support asynchronous rejecting with non error instance
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make overridden version of application exactly the one required by unit test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Mark injectable causing side effects
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Revert not required changes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make code for asserting a promise more strict
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make dependencies readonly
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove duplication for disposers
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Implement initial values for sync-boxes
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Separate concept of message and request channels
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce tests for requesting from channel in renderer
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Implement requesting from renderer in main
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Revert "Implement requesting from renderer in main"
This reverts commit d3e7899d7900516f3dbfacdb317a453202318305.
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak typing of request channel listeners to get rid of unexpected undefined
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove unused variable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak timing of sentry setup
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Require messages for MessageChannels be JsonValues for serialization
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Require requests and responses for RequestChannels be JsonValues for serialization
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make different MessageChannels not require explicit "extends JsonObject"
Note: Non-escaped lint breaks type here for forcing interface over type. Reasonable effort brought no understanding for what is the relevant difference between the two.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make a primitive argument an object for readability
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make typing of higher order function for error suppression not lie
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Serialize messages in channels to make IPC not blow up
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce a way to make intentional orphan promises uniform, controllable and deliberate
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make downloading of update and what follows more deliberate as orphan promise
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Move utility function under directory
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Move another utility function under directory
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix incorrect name of file
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove redundant code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kill dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Round percentage of update download progress in tray
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix rebase conflicts
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix CheckForUpdate type errors
Signed-off-by: Sebastian Malton <sebastian@malton.name >
Co-authored-by: Iku-turso <mikko.aspiala@gmail.com >
Co-authored-by: Sebastian Malton <sebastian@malton.name >
2022-06-03 11:21:36 +03:00
Janne Savolainen and Mikko Aspiala
54b92aa9b6
Make starting of application modular and unit testable ( #5324 )
...
* Introduce injection token as competition for injectable setup to have better control of timing of different setups
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using competition to setup app paths
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using competition for setupping IPC channel listeners
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Stop running setups in unit tests without need
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to running injection token based setups over legacy DI setups in unit tests
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate naming for running setups
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to running injection token based setups over legacy DI setups in application roots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Adapt to typing changes in injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce concept of runnable as a way to delegate runs to Open Closed Principle compliant runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Deprecate vars in favor of injectables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate loading of extensions to injectable instead of setup-code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Flag injectable causing side effects
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Adapt injectable to auto register using a plugin instead of internal feature that no longer exists
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Simplify late registrations
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce tokens for runnables of specific application events for Open Closed Principle
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate setup events to more granular timeslots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for catalog syncing using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for application menu using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for electron application name using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for immer using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for MobX strictness using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for application proxy using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for system certifications using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for system shutdown using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for main window visibility using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for application quit using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for after application is ready using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for application tray using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for deep linking using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Reimplement setup for root frame using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove multiple usages of shared global state
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove recently reimplemented stuff from index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract implementation for intent over technical phenomena (here electron events)
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Consolidate naming of event timing window
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Move directories for timing windows among peers
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Consolidate event naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce function to remove duplication from things that are startable and stoppable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Consolidate implementation of something startable and stoppable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Consolidate naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Consolidate more startables and stoppables
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce abstractions for electron application events
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce more abstractions for electron
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Abstract even more Electron specifics to make them overridable in unit tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Override dependency for causing side effects
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make running of many delegatees able to be hierarchical
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Bump async-fn
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make startable-stoppable also restartable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract "isIntegrationTesting" as dependency for having a side-effect
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make temporal dependency apparent
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate all setupping related to single feature to same runnable
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Abstract command line arguments to make them overridable in tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Deprecate some globals
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce injectable for __static directory to eliminate side effect on import
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract responsibilities from electron
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract async initialization from sync-injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Accumulate more global overrides
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make lifecycle of injectable store work as expected
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Extract responsibilities to delegatees
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Rename delegate for accuracy
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Rename another delegate for accuracy
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Rename yet another delegate for accuracy
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Add new global overrides
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Consolidate variable naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Rename injectable for accuracy
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make difference between soft and hard quit of application apparent
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make quit triggered by auto update manifest as hard quit instead of just soft quit
Soft quit is the stand-by quit where only the renderer quits. Hard quit is the full quit of also main.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Introduce abstraction for publishing and subscribing between processes
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Revert "Introduce abstraction for publishing and subscribing between processes"
This reverts commit 46f2d5a5f28bddcf5ffe124b1c590b19e7b9a15f.
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Adapt code and unit tests to recent changes in application setup and event handling
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Group overrides by category
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Abstract event of application activation from electron
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Abstract event of device shutdown from electron
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate runnables related to Electron
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make startableStoppables have ID for better error logging
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Make navigating to Helm Charts not blow up
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Add general override for behavioural tests
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi >
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com >
* Update snapshot
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Adapt vars after merge
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix code style
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix error about multiple states for React Router being present at once
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kludge around test setup which is difficult because of circular dependencies
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix setupping of sentry after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Ensure that LensProxy is setupped before starting the main window
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove redundant import
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate to use injectable instead of var for static file directory
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Deprecate another var with injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak timing of runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract tray icon path as injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make splash screen not blow up by providing compile-time environment variables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce a way to run many synchronous runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make runnables for before application is ready synchronous as this is technical limitation of Electron
See: https://github.com/electron/electron/issues/21370
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kill dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix application quit by calling Electron's event.preventDefault in a very specific way and preventing async
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix missing injectable postfix in file name
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak timeslot of a runnable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make it possible to not stop something that was never started
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make quit of hidden Lens not blow up
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract responsibilities of WindowManager as injectables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate code for application window
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Simplify directory structures for runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Flag injectable causing side-effect
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract helpers for testing promises to test-utils
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make script for running unit tests support targeting
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make startable stoppable support async starting
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce reactive way to get theme from operating system
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update yarn.lock after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix code style
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove code-style changes that are not welcome
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using dependency over using explicit side-effect
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Simplify naming
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Kill dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add empty mocks comply to lint
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove global state
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract responsibility of setting dependencies to own injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Flag injectable causing side effects
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract responsibility to injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak typing
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak naming of runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Revert code-style changes
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak types
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Extract injectable with side-effect for exact overriding
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak name of timeslot to make it more apparent that new content for application load can be added
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak name of the splash window for loading to avoid confusion with similarly named phenomenon
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Tweak comment
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Rename injectable for brevity
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate LensProxy related stuff to directory
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Rename injectables for accuracy
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove usage of extension for injectable for being YAGNI
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Prevent restarting a startableStoppable when already being started
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Rename callback in ApplicationBuilder for accuracy
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix conflicts after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix merge conflicts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Revert switch to react-router-dom by installing history as dependency
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make test more strict
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make runnable give friendly error about incorrect hierarchy for easier debugging
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix code-style
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix code style
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using dependency instead of legacy-di
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix timing of injects
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
Co-authored-by: Iku-turso <mikko.aspiala@gmail.com >
2022-05-18 16:18:02 +03:00
Janne Savolainen
6745f2efd7
Fix snapshots/code-style after merging stuff to master ( #5235 )
...
* Update snapshots after merging stuff to master
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix code style
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-04-12 15:02:34 +03:00
Janne Savolainen and Mikko Aspiala
68a605ded9
Fix returning to specific catalog tab and removing a hotbar item ( #5201 )
...
* Fix removing hot bar item
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix navigating back to tab in catalog from hotbar
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-04-12 07:34:44 +03:00
Janne Savolainen
8e8ad6663b
Fix LensRendererExtension.navigate() when extension is adding routes in "onActivate" callback ( #5166 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-04-01 14:30:15 +03:00
Janne Savolainen
61cff3eb71
Revert breaking change by making id for select optional ( #5164 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-04-01 13:36:27 +03:00
Janne Savolainen
38af26efc9
Make routes in back-end comply to Open Closed Principle ( #4859 )
...
* Make registration of back-end routes happen using injectable
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for list charts
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for get chart
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for get chart values
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for installing chart
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for updating release
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for rollbacking release
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for listing releases
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for getting release
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for getting release values
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for getting release history
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for deleting release
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove HelmRoute for not being used anymore
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for applying resource
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for patching resource
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for stopping current port forward
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for getting current port forward
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Consolidate start port forward route to use injection token for registering route
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for metrics
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for getting service account
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for getting version
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add global override for reading file to make it not required where not interesting
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Switch to using injectable to setup route for serving static files
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make adding routes private for router
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make routes wait until all asynchronous stuff are done
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Introduce healthy abstraction between back-end routes and route handlers
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make response of route typed
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix incorrect return value of updateRelease
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make typing of routes support synchronous values
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make code cleaner
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Rename test for accuracy
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Add test for throwing route handler
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove duplicate license header
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make mechanism of creating HTTP response an implementation detail
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove not needed properties from test
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix code style
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix typing and codestyle
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix typing error
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix merge conflicts
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Organize all router related files under directory
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-03-11 12:20:00 +02:00
Janne Savolainen
125a47a56d
Replace WorkloadsOverviewDetailRegistry with reactive solution ( #4817 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-03-04 10:04:38 +02:00
Janne Savolainen
54b87efd89
Replace KubeObjectStatusRegistry with reactive solution ( #4815 )
2022-03-03 07:55:57 -05:00
Janne Savolainen and Mikko Aspiala
b65f6e00ec
Update injectable library ( #4842 )
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
2022-02-25 11:10:13 -05:00
Janne Savolainen and Mikko Aspiala
81819dbbe9
Revert accidental breaking change in Extension API ( #4904 )
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-02-23 13:26:14 +02:00
Janne Savolainen
668ac58cb3
Consolidate way of passing items to ItemListLayout ( #4850 )
2022-02-11 09:32:14 -05:00
Janne Savolainen
9ea3c94c5a
Upgrade injectable to fix observation of asyncComputed when invalidated before ever observed ( #4828 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-02-07 14:02:06 +02:00
Janne Savolainen and Mikko Aspiala
09824a6e01
Prevent creation of dynamic components where withInjectables use type parameters to make React not re-mount because of dynamic components being different ( #4808 )
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-02-03 13:26:14 +02:00
Janne Savolainen and Mikko Aspiala
e58d9b631a
Fix bugs in ItemListLayouts/KubeObjectListLayouts ( #4792 )
...
* Fix virtual list behaviour in item list layout by making table rows observer
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make selecting item in ItemListLayout not scroll to top
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix scrolling to top when selecting all items in item list layout
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix refreshing release values when release is unselected
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove noisy debugging
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix sorting of table rows
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Replace avoidable asyncComputed with normal computed
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Revert unnecessary code style changes
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix render-storm in Events
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix missing key in React array
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-02-02 16:46:07 +02:00
Janne Savolainen and Mikko Aspiala
e8205a64b9
Fix bugs in helm releases ( #4785 )
...
* Fix opening of upgrade release tab
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Bring back ability to rollback to specific revision
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix helm releases not updating after rollback
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Fix helm releases not updating after upgrade
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-02-01 16:18:43 +02:00
Janne Savolainen and Sebastian Malton
ac42a6565f
Replace kube object menu registry with reactive solution ( #4731 )
...
Co-authored-by: Sebastian Malton <sebastian@malton.name >
2022-01-31 10:16:29 -05:00
Janne Savolainen
09b33633f7
Replace StatusBarRegistry with reactive solution ( #4728 )
2022-01-28 08:40:58 -05:00
Janne Savolainen and Mikko Aspiala
4f5a2988cb
Fix infinite render loop in release details ( #4710 )
...
* Fix infinite render loop in release details by replacing stateful, UI-triggered releaseStore with reactive async computed
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Update injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove unnecessary return
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove empty lines
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Allow injection of history
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make data required for opening of release details a dependency to make sure it's present
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Remove dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
* Make arriving release values not re-render whole details
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-21 16:29:10 +02:00
Janne Savolainen
589472c2b5
Shorten license header to reduce amount of clutter in top of the files ( #4709 )
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-18 10:18:10 +02:00
Janne Savolainen
84b1d9e703
Temporary disable failing integration tests to allow merging and solve issue in separate PR
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-17 18:24:17 +02:00
Janne Savolainen and Mikko Aspiala
1e772e5303
Fix import
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-14 08:05:22 +02:00
Janne Savolainen
edd9dcd44b
Fix duplicate import
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-14 08:04:25 +02:00
Janne Savolainen
00f6d6bc1f
Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths
2022-01-14 07:59:42 +02:00
Janne Savolainen
7c97303414
Remove duplicated LICENSE header
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-14 07:52:37 +02:00
Janne Savolainen and Mikko Aspiala
4e2995f979
Extract business logic from component while trying to solve re-rendering issue
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-13 09:04:15 +02:00
Janne Savolainen and Mikko Aspiala
06379b089b
Add TODO
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-13 09:01:34 +02:00
Janne Savolainen and Mikko Aspiala
09b52a59d8
Fix adding new namespace
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-12 09:06:25 +02:00
Janne Savolainen and Mikko Aspiala
ecb93393d1
Fix issue with "this"
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-11 16:18:08 +02:00
Janne Savolainen and Mikko Aspiala
070750e736
Try fixing unit test in windows
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-11 14:51:57 +02:00
Janne Savolainen and Mikko Aspiala
883ece7ea2
Make unit test not fail on windows
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-11 14:34:46 +02:00
Janne Savolainen and Mikko Aspiala
977c6bd2c7
Move file to proper directory
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-11 14:05:04 +02:00
Janne Savolainen
0f33ba18d2
Simplify function
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-11 14:04:06 +02:00
Janne Savolainen
995983f0b0
Fix code style
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-11 14:03:51 +02:00
Janne Savolainen
8d87bd0985
Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-11 13:56:23 +02:00
Janne Savolainen
f7f27a8304
Merge pull request #4424 from lensapp/issue-3258
...
Command Palette Improvements
2022-01-11 09:20:02 +02:00
Janne Savolainen and Mikko Aspiala
a1fd61e41b
Mark electron to cause side effects in unit tests
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-11 09:12:23 +02:00
Janne Savolainen and Mikko Aspiala
b157bda76b
Fix deprecated comment
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-11 09:10:43 +02:00
Janne Savolainen
e1a6d4c4a9
Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths
2022-01-10 17:13:20 +02:00
Janne Savolainen and Mikko Aspiala
d853898a48
Update injectable
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-10 16:54:04 +02:00
Janne Savolainen and Mikko Aspiala
4b46f1fe02
Override a side effect in unit test
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-10 16:54:04 +02:00
Janne Savolainen and Mikko Aspiala
ae1d3a2712
Revert breaking change
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-10 16:54:04 +02:00
Janne Savolainen and Mikko Aspiala
eeff7e488f
Fix changing between cluster metrics
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-10 16:54:04 +02:00
Janne Savolainen and Mikko Aspiala
4d5e2bd812
Remove component observation causing involuntary re-renders
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-10 16:54:03 +02:00
Janne Savolainen
48948c7286
Fix endless re-rending of logs
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-10 16:54:03 +02:00
Janne Savolainen
4441d714dd
Fix issue with opening of terminal
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-07 19:29:24 +02:00
Janne Savolainen and Mikko Aspiala
ff9e9bd169
Re-implement some Extension API features using injectables
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-07 12:10:02 +02:00
Janne Savolainen
4224937260
Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-05 15:04:43 +02:00
Janne Savolainen and Mikko Aspiala
9d33fff906
Cascade different refactorings to eliminate global shared state from app paths
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2022-01-05 13:26:49 +02:00
Janne Savolainen
58ea0dc822
Merge pull request #4613 from jansav/top-bar-registry
...
Replace TopBarRegistry with reactive solution
2021-12-31 12:03:51 +02:00
Janne Savolainen
71388a0ea3
Switch typing of a component to props instead of React.FC
...
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2021-12-31 09:32:24 +02:00
Janne Savolainen and Mikko Aspiala
6ca58570b0
Replace TopBarRegistry with reactive solution
...
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com >
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi >
2021-12-31 09:32:19 +02:00
Janne Savolainen
ed7d2889e2
Merge pull request #4615 from jansav/welcome-menu-registry
...
Replace WelcomeMenuRegistry and WelcomeBannerRegistry with reactive solution
2021-12-31 09:28:29 +02:00
