Commit Graph
6 Commits
Author SHA1 Message Date
Juho Heikka 8bbaf8c59e Add terminal copy on select (#3904) 2021-09-29 08:55:39 -04:00
Juho Heikka b41f923931 Merge pull request #3866 from lensapp/issue-3383-menu-position-bug
Fix menu rendering on when slightly off screen
2021-09-29 09:36:25 +03:00
Juho Heikka b70ec5ddbd Remove shouldComponentUpdate, put style to state
instead of straight to DOM so they will be in sync

Signed-off-by: Juho Heikka <juho.heikka@gmail.com>
2021-09-27 17:03:27 +03:00
Juho Heikka 2e1b3ea70c Merge branch 'master' into issue-3383-menu-position-bug 2021-09-27 13:35:39 +03:00
Juho Heikka eb789a0ab1 Fix menu rendering on when slightly off screen
Menu would bounce around in some cases because the
refreshPosition() would calculate different results
based on different state of the component and previous
render cycle CSS classes.

Also I found that the render function calls causes
in an infinite loop while open because of refreshPosition
will cause a state change which will rerender the function.
Fixed that with the shouldComponentUpdate which checks
if state has actually changed in between renders.

Signed-off-by: Juho Heikka <juho.heikka@gmail.com>
2021-09-22 09:42:51 +03:00
Juho Heikka 74f3826235 Second click on list item closes the details view (#3809)
Signed-off-by: Juho Heikka <juho.heikka@gmail.com>
2021-09-15 08:48:12 -04:00