90 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Janne SavolainenandMikko Aspiala	54b92aa9b6	Make starting of application modular and unit testable (#5324) ... * Introduce injection token as competition for injectable setup to have better control of timing of different setups Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using competition to setup app paths Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using competition for setupping IPC channel listeners Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Stop running setups in unit tests without need Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to running injection token based setups over legacy DI setups in unit tests Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Consolidate naming for running setups Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to running injection token based setups over legacy DI setups in application roots Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Adapt to typing changes in injectable Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Update injectable Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce concept of runnable as a way to delegate runs to Open Closed Principle compliant runnables Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Deprecate vars in favor of injectables Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Consolidate loading of extensions to injectable instead of setup-code Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Flag injectable causing side effects Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Adapt injectable to auto register using a plugin instead of internal feature that no longer exists Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Simplify late registrations Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce tokens for runnables of specific application events for Open Closed Principle Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Consolidate setup events to more granular timeslots Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for catalog syncing using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for application menu using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for electron application name using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for immer using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for MobX strictness using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for application proxy using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for system certifications using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for system shutdown using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for main window visibility using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for application quit using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for after application is ready using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for application tray using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for deep linking using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Reimplement setup for root frame using runnables instead of non-OCP in index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove multiple usages of shared global state Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove recently reimplemented stuff from index.ts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract implementation for intent over technical phenomena (here electron events) Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Consolidate naming of event timing window Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Move directories for timing windows among peers Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Consolidate event naming Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Introduce function to remove duplication from things that are startable and stoppable Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Consolidate implementation of something startable and stoppable Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Consolidate naming Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Consolidate more startables and stoppables Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Introduce abstractions for electron application events Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce more abstractions for electron Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Abstract even more Electron specifics to make them overridable in unit tests Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Override dependency for causing side effects Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make running of many delegatees able to be hierarchical Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Bump async-fn Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make startable-stoppable also restartable Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Extract "isIntegrationTesting" as dependency for having a side-effect Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make temporal dependency apparent Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Consolidate all setupping related to single feature to same runnable Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Abstract command line arguments to make them overridable in tests Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Deprecate some globals Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce injectable for __static directory to eliminate side effect on import Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract responsibilities from electron Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract async initialization from sync-injectable Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Accumulate more global overrides Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make lifecycle of injectable store work as expected Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Extract responsibilities to delegatees Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Rename delegate for accuracy Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Rename another delegate for accuracy Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Rename yet another delegate for accuracy Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Add new global overrides Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Consolidate variable naming Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Rename injectable for accuracy Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make difference between soft and hard quit of application apparent Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make quit triggered by auto update manifest as hard quit instead of just soft quit Soft quit is the stand-by quit where only the renderer quits. Hard quit is the full quit of also main. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Introduce abstraction for publishing and subscribing between processes Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Revert "Introduce abstraction for publishing and subscribing between processes" This reverts commit 46f2d5a5f28bddcf5ffe124b1c590b19e7b9a15f. Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Adapt code and unit tests to recent changes in application setup and event handling Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Group overrides by category Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Abstract event of application activation from electron Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Abstract event of device shutdown from electron Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Consolidate runnables related to Electron Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make startableStoppables have ID for better error logging Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make navigating to Helm Charts not blow up Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Add general override for behavioural tests Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Update snapshot Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Adapt vars after merge Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix code style Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix error about multiple states for React Router being present at once Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Kludge around test setup which is difficult because of circular dependencies Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix setupping of sentry after rebase Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Ensure that LensProxy is setupped before starting the main window Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove redundant import Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Consolidate to use injectable instead of var for static file directory Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Deprecate another var with injectable Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Tweak timing of runnables Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract tray icon path as injectable Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make splash screen not blow up by providing compile-time environment variables Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce a way to run many synchronous runnables Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make runnables for before application is ready synchronous as this is technical limitation of Electron See: https://github.com/electron/electron/issues/21370 Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Kill dead code Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix application quit by calling Electron's event.preventDefault in a very specific way and preventing async Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix missing injectable postfix in file name Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Tweak timeslot of a runnable Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make it possible to not stop something that was never started Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make quit of hidden Lens not blow up Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract responsibilities of WindowManager as injectables Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Consolidate code for application window Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Simplify directory structures for runnables Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Flag injectable causing side-effect Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract helpers for testing promises to test-utils Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make script for running unit tests support targeting Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make startable stoppable support async starting Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce reactive way to get theme from operating system Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Update yarn.lock after rebase Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix code style Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove code-style changes that are not welcome Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using dependency over using explicit side-effect Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Simplify naming Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Kill dead code Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add empty mocks comply to lint Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove global state Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract responsibility of setting dependencies to own injectable Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Flag injectable causing side effects Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract responsibility to injectable Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Tweak typing Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Tweak naming of runnables Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Revert code-style changes Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Tweak types Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract injectable with side-effect for exact overriding Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Tweak name of timeslot to make it more apparent that new content for application load can be added Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Tweak name of the splash window for loading to avoid confusion with similarly named phenomenon Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Tweak comment Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Rename injectable for brevity Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Consolidate LensProxy related stuff to directory Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Rename injectables for accuracy Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove usage of extension for injectable for being YAGNI Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Prevent restarting a startableStoppable when already being started Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Rename callback in ApplicationBuilder for accuracy Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix conflicts after rebase Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix merge conflicts Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Revert switch to react-router-dom by installing history as dependency Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make test more strict Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make runnable give friendly error about incorrect hierarchy for easier debugging Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix code-style Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix code style Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using dependency instead of legacy-di Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix timing of injects Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> Co-authored-by: Iku-turso <mikko.aspiala@gmail.com>	2022-05-18 16:18:02 +03:00
Janne Savolainen	6745f2efd7	Fix snapshots/code-style after merging stuff to master (#5235) ... * Update snapshots after merging stuff to master Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix code style Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-04-12 15:02:34 +03:00
Janne SavolainenandMikko Aspiala	68a605ded9	Fix returning to specific catalog tab and removing a hotbar item (#5201) ... * Fix removing hot bar item Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix navigating back to tab in catalog from hotbar Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-04-12 07:34:44 +03:00
Janne Savolainen	8e8ad6663b	Fix LensRendererExtension.navigate() when extension is adding routes in "onActivate" callback (#5166) ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-04-01 14:30:15 +03:00
Janne Savolainen	61cff3eb71	Revert breaking change by making id for select optional (#5164) ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-04-01 13:36:27 +03:00
Janne Savolainen	38af26efc9	Make routes in back-end comply to Open Closed Principle (#4859) ... * Make registration of back-end routes happen using injectable Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for list charts Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for get chart Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for get chart values Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for installing chart Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for updating release Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for rollbacking release Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for listing releases Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for getting release Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for getting release values Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for getting release history Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for deleting release Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove HelmRoute for not being used anymore Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for applying resource Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for patching resource Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for stopping current port forward Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for getting current port forward Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Consolidate start port forward route to use injection token for registering route Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for metrics Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for getting service account Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for getting version Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add global override for reading file to make it not required where not interesting Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using injectable to setup route for serving static files Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make adding routes private for router Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make routes wait until all asynchronous stuff are done Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce healthy abstraction between back-end routes and route handlers Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make response of route typed Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix incorrect return value of updateRelease Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make typing of routes support synchronous values Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make code cleaner Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Rename test for accuracy Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add test for throwing route handler Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove duplicate license header Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make mechanism of creating HTTP response an implementation detail Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove not needed properties from test Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix code style Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix typing and codestyle Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix typing error Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix merge conflicts Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Organize all router related files under directory Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-03-11 12:20:00 +02:00
Janne Savolainen	125a47a56d	Replace WorkloadsOverviewDetailRegistry with reactive solution (#4817) ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-03-04 10:04:38 +02:00
Janne Savolainen	54b87efd89	Replace KubeObjectStatusRegistry with reactive solution (#4815)	2022-03-03 07:55:57 -05:00
Janne SavolainenandMikko Aspiala	b65f6e00ec	Update injectable library (#4842) ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>	2022-02-25 11:10:13 -05:00
Janne SavolainenandMikko Aspiala	81819dbbe9	Revert accidental breaking change in Extension API (#4904) ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-02-23 13:26:14 +02:00
Janne Savolainen	668ac58cb3	Consolidate way of passing items to ItemListLayout (#4850)	2022-02-11 09:32:14 -05:00
Janne Savolainen	9ea3c94c5a	Upgrade injectable to fix observation of asyncComputed when invalidated before ever observed (#4828) ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-02-07 14:02:06 +02:00
Janne SavolainenandMikko Aspiala	09824a6e01	Prevent creation of dynamic components where withInjectables use type parameters to make React not re-mount because of dynamic components being different (#4808) ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-02-03 13:26:14 +02:00
Janne SavolainenandMikko Aspiala	e58d9b631a	Fix bugs in ItemListLayouts/KubeObjectListLayouts (#4792) ... * Fix virtual list behaviour in item list layout by making table rows observer Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make selecting item in ItemListLayout not scroll to top Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix scrolling to top when selecting all items in item list layout Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix refreshing release values when release is unselected Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove noisy debugging Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix sorting of table rows Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Replace avoidable asyncComputed with normal computed Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Revert unnecessary code style changes Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix render-storm in Events Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix missing key in React array Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-02-02 16:46:07 +02:00
Janne SavolainenandMikko Aspiala	e8205a64b9	Fix bugs in helm releases (#4785) ... * Fix opening of upgrade release tab Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Bring back ability to rollback to specific revision Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix helm releases not updating after rollback Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix helm releases not updating after upgrade Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-02-01 16:18:43 +02:00
Janne SavolainenandSebastian Malton	ac42a6565f	Replace kube object menu registry with reactive solution (#4731) ... Co-authored-by: Sebastian Malton <sebastian@malton.name>	2022-01-31 10:16:29 -05:00
Janne Savolainen	09b33633f7	Replace StatusBarRegistry with reactive solution (#4728)	2022-01-28 08:40:58 -05:00
Janne SavolainenandMikko Aspiala	4f5a2988cb	Fix infinite render loop in release details (#4710) ... * Fix infinite render loop in release details by replacing stateful, UI-triggered releaseStore with reactive async computed Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Update injectable Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove unnecessary return Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove empty lines Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Allow injection of history Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make data required for opening of release details a dependency to make sure it's present Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove dead code Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make arriving release values not re-render whole details Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-21 16:29:10 +02:00
Janne Savolainen	589472c2b5	Shorten license header to reduce amount of clutter in top of the files (#4709) ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-18 10:18:10 +02:00
Janne Savolainen	84b1d9e703	Temporary disable failing integration tests to allow merging and solve issue in separate PR ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-17 18:24:17 +02:00
Janne SavolainenandMikko Aspiala	1e772e5303	Fix import ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-14 08:05:22 +02:00
Janne Savolainen	edd9dcd44b	Fix duplicate import ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-14 08:04:25 +02:00
Janne Savolainen	00f6d6bc1f	Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths	2022-01-14 07:59:42 +02:00
Janne Savolainen	7c97303414	Remove duplicated LICENSE header ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-14 07:52:37 +02:00
Janne SavolainenandMikko Aspiala	4e2995f979	Extract business logic from component while trying to solve re-rendering issue ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-13 09:04:15 +02:00
Janne SavolainenandMikko Aspiala	06379b089b	Add TODO ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-13 09:01:34 +02:00
Janne SavolainenandMikko Aspiala	09b52a59d8	Fix adding new namespace ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-12 09:06:25 +02:00
Janne SavolainenandMikko Aspiala	ecb93393d1	Fix issue with "this" ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-11 16:18:08 +02:00
Janne SavolainenandMikko Aspiala	070750e736	Try fixing unit test in windows ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-11 14:51:57 +02:00
Janne SavolainenandMikko Aspiala	883ece7ea2	Make unit test not fail on windows ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-11 14:34:46 +02:00
Janne SavolainenandMikko Aspiala	977c6bd2c7	Move file to proper directory ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-11 14:05:04 +02:00
Janne Savolainen	0f33ba18d2	Simplify function ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-11 14:04:06 +02:00
Janne Savolainen	995983f0b0	Fix code style ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-11 14:03:51 +02:00
Janne Savolainen	8d87bd0985	Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-11 13:56:23 +02:00
Janne Savolainen	f7f27a8304	Merge pull request #4424 from lensapp/issue-3258 ... Command Palette Improvements	2022-01-11 09:20:02 +02:00
Janne SavolainenandMikko Aspiala	a1fd61e41b	Mark electron to cause side effects in unit tests ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-11 09:12:23 +02:00
Janne SavolainenandMikko Aspiala	b157bda76b	Fix deprecated comment ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-11 09:10:43 +02:00
Janne Savolainen	e1a6d4c4a9	Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths	2022-01-10 17:13:20 +02:00
Janne SavolainenandMikko Aspiala	d853898a48	Update injectable ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-10 16:54:04 +02:00
Janne SavolainenandMikko Aspiala	4b46f1fe02	Override a side effect in unit test ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-10 16:54:04 +02:00
Janne SavolainenandMikko Aspiala	ae1d3a2712	Revert breaking change ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-10 16:54:04 +02:00
Janne SavolainenandMikko Aspiala	eeff7e488f	Fix changing between cluster metrics ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-10 16:54:04 +02:00
Janne SavolainenandMikko Aspiala	4d5e2bd812	Remove component observation causing involuntary re-renders ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-10 16:54:03 +02:00
Janne Savolainen	48948c7286	Fix endless re-rending of logs ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-10 16:54:03 +02:00
Janne Savolainen	4441d714dd	Fix issue with opening of terminal ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-07 19:29:24 +02:00
Janne SavolainenandMikko Aspiala	ff9e9bd169	Re-implement some Extension API features using injectables ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-07 12:10:02 +02:00
Janne Savolainen	4224937260	Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-05 15:04:43 +02:00
Janne SavolainenandMikko Aspiala	9d33fff906	Cascade different refactorings to eliminate global shared state from app paths ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-01-05 13:26:49 +02:00
Janne Savolainen	58ea0dc822	Merge pull request #4613 from jansav/top-bar-registry ... Replace TopBarRegistry with reactive solution	2021-12-31 12:03:51 +02:00
Janne Savolainen	71388a0ea3	Switch typing of a component to props instead of React.FC ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-31 09:32:24 +02:00
Janne SavolainenandMikko Aspiala	6ca58570b0	Replace TopBarRegistry with reactive solution ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-31 09:32:19 +02:00
Janne Savolainen	ed7d2889e2	Merge pull request #4615 from jansav/welcome-menu-registry ... Replace WelcomeMenuRegistry and WelcomeBannerRegistry with reactive solution	2021-12-31 09:28:29 +02:00
Janne SavolainenandMikko Aspiala	c5613a2e6a	Remove WelcomeBannerRegistry in favor of reactive solution ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-28 13:55:55 +02:00
Janne SavolainenandMikko Aspiala	04ac2ff3dd	Remove WelcomeMenuRegistry in favor of reactive solution ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-28 13:55:54 +02:00
Janne SavolainenandMikko Aspiala	ab4a8c8a1d	Convert a class component to functional component ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-28 13:55:50 +02:00
Janne SavolainenandMikko Aspiala	908a40975e	Extract minimal dependencies over a god class to satisfy Interface Segregation Principle and make stubbing in unit testing easier ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-28 11:51:35 +02:00
Janne SavolainenandMikko Aspiala	13873f5d85	Replace a dependency to full implementation with an interface to allow minimal stubbing ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-28 11:51:34 +02:00
Janne SavolainenandMikko Aspiala	a9189f82e6	Stop using global shared state for ExtensionDiscovery and it's relatives ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-28 11:51:34 +02:00
Janne Savolainen	41aacb3db2	Merge pull request #4612 from jansav/update-injectable ... Adapt to recent simplifications in injectable	2021-12-28 11:51:11 +02:00
Janne SavolainenandMikko Aspiala	5325b902b6	Fix code style ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-27 14:17:40 +02:00
Janne SavolainenandMikko Aspiala	c2e5df0c84	Stop exporting dependencies for being redundant ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-27 14:17:39 +02:00
Janne SavolainenandMikko Aspiala	6f0686e9a4	Adapt to changes in injectable ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-27 14:17:38 +02:00
Janne SavolainenandMikko Aspiala	8a78c73e19	Update ogre-tools and async-fn ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-27 14:17:37 +02:00
Janne Savolainen	a711499bb6	Update ogre-tools for improved types of withInjectables (#4587)	2021-12-17 10:28:26 -05:00
Janne Savolainen	3418c0acfe	Merge pull request #4527 from jansav/make-menu-registry-obsolete ... Remove MenuRegistry in favour of dependency injection	2021-12-16 15:11:30 +02:00
Janne Savolainen	c0a0127d2d	Merge pull request #4557 from lensapp/remove-weird-whitespace ... Remove all 'NonBreakingSpace' characters from the repo	2021-12-16 08:38:55 +02:00
Janne Savolainen	f56f3be79b	Merge pull request #4569 from lensapp/issue-4567 ... Fix crash with InstallChart	2021-12-16 08:27:20 +02:00
Janne Savolainen	8337dfd21b	Fix test that was accidentally broken ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-16 07:14:16 +02:00
Janne Savolainen	250b301655	Revert code style change ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-16 07:14:16 +02:00
Janne Savolainen	a2486da0eb	Fix linting ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-16 07:14:15 +02:00
Janne Savolainen	2189679a30	Merge remote-tracking branch 'upstream/master' into make-menu-registry-obsolete ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-15 16:14:08 +02:00
Janne Savolainen	9f7515db0e	Revert "Introduce a way to start replacing usages of Singleton base-class with no changes required on use places" ... This reverts commit 34a47f5f Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-15 15:37:37 +02:00
Janne Savolainen	c92c8f8a11	Replace global state usages of ExtensionLoader with DI ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-15 15:37:36 +02:00
Janne Savolainen	0b172de741	Adapt to change in DI to minimize boilerplate ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-15 15:13:43 +02:00
Janne Savolainen	b4a1c2af9f	Make ExtensionLoader injectable to avoid confusion when instance should be created ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-09 08:14:15 +02:00
Janne Savolainen	34a47f5f44	Introduce a way to start replacing usages of Singleton base-class with no changes required on use places ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-09 08:09:49 +02:00
Janne Savolainen	f9cf08b4a8	Make sure that extensions have been initialized before exposing them as enabled extensions ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-09 07:41:43 +02:00
Janne Savolainen	41837e86bb	Remove forgotten console.log used for debug ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-08 14:17:15 +02:00
Janne Savolainen	717b62d2e6	Remove obsolete code ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-12-08 13:10:50 +02:00
Janne SavolainenandMikko Aspiala	67c24cac9a	Switch to getting menu items by observing change in extensions instead local state ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>	2021-12-08 13:10:50 +02:00
4 people	7ed50f83fc	Add breadcrumbs to removal of kube objects, but also discuss about general improvements (#4282) ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Co-authored-by: Janne Savolainen <janne.savolainen@houston-inc.com> Co-authored-by: Mikko Aspiala <mikko.aspiala@houston-inc.com>	2021-12-06 13:05:05 -05:00
Janne Savolainen	f6a51d1ae7	Merge pull request #4338 from jansav/feature/injectable ... Introduce a way to use injectables	2021-11-26 11:50:01 +02:00
Janne Savolainen	7b6a7059bf	Move types of injectable and injectable-react to the library ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-11-26 07:44:35 +02:00
Janne Savolainen	c9503c1d14	Allow asynchronous instances in injectable typing ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-11-26 07:44:30 +02:00
Janne Savolainen	0c0dfe5966	Make overriding injectable with a mock supported ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-11-26 07:44:30 +02:00
Janne Savolainen	d07d9f9fd2	Update version of injectable library ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-11-26 07:44:30 +02:00
Janne Savolainen	0af1d08299	Fix linting in type definition ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-11-26 07:44:20 +02:00
Janne Savolainen	c4c4bc5845	Introduce a way to use injectables for UI ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2021-11-26 07:44:17 +02:00
Janne SavolainenandMikko Aspiala	e146dff9da	Prefer ref over findDOMNode to make unit tests not flaky (#4372) ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>	2021-11-17 11:38:42 -05:00
Janne Savolainen	262f471da8	Add default WebStorm configuration files (#4293) ... Signed-off-by: Janne Savolainen <janne.savolainen@houston-inc.com>	2021-11-09 11:55:09 +02:00