mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Add reaction cleanup
Signed-off-by: DmitriyNoa <dmytro.zharkov@gmail.com>
This commit is contained in:
parent
6746ae489f
commit
1c55fe6167
@ -101,8 +101,6 @@ export const DockTabs = ({ tabs, autoFocus, selectedTab, onChangeTab, dockStore
|
||||
|
||||
|
||||
useEffect(() => {
|
||||
updateStateValues();
|
||||
|
||||
// update values in store on scroll
|
||||
elem.current.addEventListener("scroll", updateScrollPosition);
|
||||
|
||||
@ -110,11 +108,12 @@ export const DockTabs = ({ tabs, autoFocus, selectedTab, onChangeTab, dockStore
|
||||
window.addEventListener("resize", onWindowResize);
|
||||
|
||||
// update scroll state if tabs numbers has changed
|
||||
reaction(() => dockStore.tabsNumber, updateStateValues, { fireImmediately: true });
|
||||
const tabsNumberChangeDisposer = reaction(() => dockStore.tabsNumber, updateStateValues, { fireImmediately: true });
|
||||
|
||||
return () => {
|
||||
window.removeEventListener("resize", onWindowResize);
|
||||
elem.current.removeEventListener("scroll", updateScrollPosition);
|
||||
tabsNumberChangeDisposer();
|
||||
};
|
||||
}, []);
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user