hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Add reaction cleanup

Browse Source 
Signed-off-by: DmitriyNoa <dmytro.zharkov@gmail.com>
This commit is contained in:
DmitriyNoa 2022-01-31 16:37:54 +01:00
parent 6746ae489f
commit 1c55fe6167
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/renderer/components/dock/dock-tabs.tsx
View File

@ -101,8 +101,6 @@ export const DockTabs = ({ tabs, autoFocus, selectedTab, onChangeTab, dockStore
useEffect(() => { useEffect(() => {
updateStateValues();
// update values in store on scroll // update values in store on scroll
elem.current.addEventListener("scroll", updateScrollPosition); elem.current.addEventListener("scroll", updateScrollPosition);
@ -110,11 +108,12 @@ export const DockTabs = ({ tabs, autoFocus, selectedTab, onChangeTab, dockStore
window.addEventListener("resize", onWindowResize); window.addEventListener("resize", onWindowResize);
// update scroll state if tabs numbers has changed // update scroll state if tabs numbers has changed
reaction(() => dockStore.tabsNumber, updateStateValues, { fireImmediately: true }); const tabsNumberChangeDisposer = reaction(() => dockStore.tabsNumber, updateStateValues, { fireImmediately: true });
return () => { return () => {
window.removeEventListener("resize", onWindowResize); window.removeEventListener("resize", onWindowResize);
elem.current.removeEventListener("scroll", updateScrollPosition); elem.current.removeEventListener("scroll", updateScrollPosition);
tabsNumberChangeDisposer();
}; };
}, []); }, []);