hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Remove unnecessary return

Browse Source 
Signed-off-by: Juho Heikka <juho.heikka@gmail.com>
This commit is contained in:
Juho Heikka 2023-02-21 09:24:01 +02:00
parent 9405899012
commit 4b6bfc1232
2 changed files with 1 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/src/extensions/extension-loader/file-system-provisioner-store/get-path-to-legacy-package-json.injectable.ts
View File

@ -15,9 +15,7 @@ const getPathToLegacyPackageJson = getInjectable({
const directoryForUserData = di.inject(directoryForUserDataInjectable);
const joinPaths = di.inject(joinPathsInjectable);
return (extensionName: string) => {
return joinPaths(directoryForUserData, "node_modules", extensionName, "package.json");
};
return (extensionName: string) => joinPaths(directoryForUserData, "node_modules", extensionName, "package.json");
},
});

34
packages/core/src/extensions/extension-loader/file-system-provisioner-store/get-path-to-legacy-package-json.test.ts
View File

@ -1,34 +0,0 @@
/**
* Copyright (c) OpenLens Authors. All rights reserved.
* Licensed under MIT License. See LICENSE in root directory for more information.
*/
import directoryForUserDataInjectable from "../../../common/app-paths/directory-for-user-data/directory-for-user-data.injectable";
import { getDiForUnitTesting } from "../../../main/getDiForUnitTesting";
import type { GetPathToLegacyPackageJson } from "./get-path-to-legacy-package-json.injectable";
import getPathToLegacyPackageJsonInjectable from "./get-path-to-legacy-package-json.injectable";
describe("get-legacy-path-for-extension-name", () => {
let getPathToLegacyPackageJson: GetPathToLegacyPackageJson;
beforeEach(() => {
const di = getDiForUnitTesting({ doGeneralOverrides: true });
const directoryForExtensionDataMock = jest.fn().mockReturnValue("/path/to/user/data");
di.override(directoryForUserDataInjectable, directoryForExtensionDataMock);
getPathToLegacyPackageJson = di.inject(getPathToLegacyPackageJsonInjectable);
});
describe("given extension name", () => {
it("given some extension returns path for package.json in user data directory", () => {
const pathToExtensionPackageJson = getPathToLegacyPackageJson("some-extension");
expect(pathToExtensionPackageJson).toEqual("/path/to/user/data/node_modules/some-extension/package.json");
});
it("given some other extension returns path for package.json in user data directory", () => {
const pathToExtensionPackageJson = getPathToLegacyPackageJson("some-other-extension");
expect(pathToExtensionPackageJson).toEqual("/path/to/user/data/node_modules/some-other-extension/package.json");
});
});
});