1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

Little clean up

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2022-05-05 11:48:03 +03:00
parent 4b074d981b
commit 9527ee8355
4 changed files with 21 additions and 21 deletions

View File

@ -3,14 +3,14 @@
exports[`preferences - navigation to extension specific preferences given in preferences, when rendered given extension with registered tab shows extension tab in general area 1`] = `
<div
class="Tab flex gaps align-center"
data-testid="tab-link-for-extension-specific-tab-navigation-item-license-extension-tab"
data-testid="tab-link-for-extension-specific-tab-navigation-item-metrics-extension-tab"
role="tab"
tabindex="0"
>
<div
class="label"
>
License tab
Metrics tab
</div>
</div>
`;
@ -97,14 +97,14 @@ exports[`preferences - navigation to extension specific preferences given in pre
</div>
<div
class="Tab flex gaps align-center active"
data-testid="tab-link-for-extension-specific-tab-navigation-item-license-extension-tab"
data-testid="tab-link-for-extension-specific-tab-navigation-item-metrics-extension-tab"
role="tab"
tabindex="0"
>
<div
class="label"
>
License tab
Metrics tab
</div>
</div>
</div>
@ -126,8 +126,8 @@ exports[`preferences - navigation to extension specific preferences given in pre
</h2>
<section
class="small"
data-testid="extension-preference-item-for-license-preference-item-id"
id="license-preference-item-id"
data-testid="extension-preference-item-for-metrics-preference-item-id"
id="metrics-preference-item-id"
>
<div
class="SubTitle"
@ -136,13 +136,13 @@ exports[`preferences - navigation to extension specific preferences given in pre
</div>
<div
data-testid="license-preference-item-input"
data-testid="metrics-preference-item-input"
/>
<div
class="hint"
>
<div
data-testid="license-preference-item-hint"
data-testid="metrics-preference-item-hint"
/>
</div>
</section>

View File

@ -174,7 +174,7 @@ describe("preferences - navigation to extension specific preferences", () => {
});
it("shows extension tab in general area", () => {
const actual = rendered.getByTestId("tab-link-for-extension-specific-tab-navigation-item-license-extension-tab");
const actual = rendered.getByTestId("tab-link-for-extension-specific-tab-navigation-item-metrics-extension-tab");
expect(actual).toMatchSnapshot();
});
@ -187,13 +187,13 @@ describe("preferences - navigation to extension specific preferences", () => {
describe("when navigating to specific extension tab", () => {
beforeEach(() => {
applicationBuilder.preferences.navigation.click("extension-specific-tab-navigation-item-license-extension-tab");
applicationBuilder.preferences.navigation.click("extension-specific-tab-navigation-item-metrics-extension-tab");
});
it("renders", () => {
expect(rendered.container).toMatchSnapshot();
});
it("shows related preferences for this tab", () => {
const actual = rendered.getByTestId("license-preference-item-hint");
const actual = rendered.getByTestId("metrics-preference-item-hint");
expect(actual).toBeInTheDocument();
});
@ -277,12 +277,12 @@ const extensionStubWithWithRegisteredTab: Partial<LensRendererExtension> = {
appPreferences: [
{
title: "License item",
id: "license-preference-item-id",
showInPreferencesTab: "license-extension-tab",
id: "metrics-preference-item-id",
showInPreferencesTab: "metrics-extension-tab",
components: {
Hint: () => <div data-testid="license-preference-item-hint" />,
Input: () => <div data-testid="license-preference-item-input" />,
Hint: () => <div data-testid="metrics-preference-item-hint" />,
Input: () => <div data-testid="metrics-preference-item-input" />,
},
},
{
@ -308,8 +308,8 @@ const extensionStubWithWithRegisteredTab: Partial<LensRendererExtension> = {
],
appPreferenceTabs: [{
title: "License tab",
id: "license-extension-tab",
title: "Metrics tab",
id: "metrics-extension-tab",
orderNumber: 100,
}],
};

View File

@ -53,7 +53,7 @@ describe("<Extensions/>", () => {
describe("when tabId param is passed and extension has same showInPreferencesTab param", () => {
beforeEach(() => {
di.override(currentPathParametersInjectable, () => computed(() => ({ extensionId: "some-test-extension-id", tabId: "license-extension-tab" })));
di.override(currentPathParametersInjectable, () => computed(() => ({ extensionId: "some-test-extension-id", tabId: "metircs-extension-tab" })));
});
it("does render related preferences for specific tab", () => {
@ -107,7 +107,7 @@ const extensionWithSpecificPreferenceItems: Partial<LensRendererExtension> = {
{
title: "preference for specific tab",
id: "preference-for-tab-item-id",
showInPreferencesTab: "license-extension-tab",
showInPreferencesTab: "metircs-extension-tab",
components: {
Hint: () => <div />,
@ -117,8 +117,8 @@ const extensionWithSpecificPreferenceItems: Partial<LensRendererExtension> = {
],
appPreferenceTabs: [{
title: "License tab",
id: "license-extension-tab",
title: "Metrics tab",
id: "metircs-extension-tab",
orderNumber: 100,
}],
};