hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix typings for KubeObjectDetailsRegistration

Browse Source 
- Allows correct subtyping of component props

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2021-07-20 16:51:32 -04:00
parent 66820a20fc
commit cc4bd9a00b
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/extensions/registries/kube-object-detail-registry.ts
View File

@ -24,14 +24,14 @@ import type { KubeObjectDetailsProps } from "../renderer-api/components";
import type { KubeObject } from "../renderer-api/k8s-api";
import { BaseRegistry } from "./base-registry";
export interface KubeObjectDetailComponents {
Details: React.ComponentType<KubeObjectDetailsProps<KubeObject>>;
export interface KubeObjectDetailComponents<T extends KubeObject> {
Details: React.ComponentType<KubeObjectDetailsProps<T>>;
}
export interface KubeObjectDetailRegistration {
kind: string;
apiVersions: string[];
components: KubeObjectDetailComponents;
components: KubeObjectDetailComponents<KubeObject>;
priority?: number;
}

2
src/renderer/components/kube-object/kube-object-details.tsx
View File

@ -82,7 +82,7 @@ export function getDetailsUrl(selfLink: string, resetSelected = false, mergeGlob
return `?${params}`;
}
export interface KubeObjectDetailsProps<T = KubeObject> {
export interface KubeObjectDetailsProps<T extends KubeObject> {
className?: string;
object: T;
}