142 Commits

Author	SHA1	Message	Date
Iku-turso	867be0562f	Make more showables maybe showable ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:42:20 +03:00
Iku-turso	95cba7a061	Extract being maybe Showable as explicit composable responsibility ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	fc2cf4f457	Simplify usages of Orderable and Showable ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	b4f48a30cc	Make non-shown application menu items not break composite structure ... This was made apparent by adding related unit tests for all known environments. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	7048683c14	Simplify "Showable" ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	c6782954b1	Make attempts to log error throw in unit tests ... Errors cannot be allowed to happen without a unit test explicitly causing it. Errors cannot be allowed to happen without author of unit test knowing it. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:37:10 +03:00
Janne Savolainen	1eb45ac1a4	Consolidate output of get-composite-path to match find-composite's input ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 09:28:46 +03:00
Iku-turso	20aaaafce3	Adapt application builder and tests to array-like paths over string-like paths ... Array-like paths do not have weakness for special characters as part of id, such as ".". Also note: the error messaging for clicking of application menu in application builder is a bit worse now I think, but the simplification of the test code is worth it in this case IMHO. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 16:04:17 +03:00
Iku-turso	4c31f4f6a7	Adapt application builder and tests to array-like paths over string-like paths ... Array-like paths do not have weakness for special characters as part of id, such as ".". Also note: the error messaging for clicking of application menu in application builder is a bit worse now I think, but the simplification of the test code is worth it in this case IMHO. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 15:20:01 +03:00
Janne Savolainen	8f39e86b15	Fix lint error ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:26 +03:00
Janne Savolainen	70088bb4d1	Update snapshots ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:26 +03:00
Iku-turso	067ecd0eee	Remove additional separators when separated items are not shown for having no content ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:26 +03:00
Iku-turso	18f1e1b6aa	Extract responsibility of "separability" ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:26 +03:00
Iku-turso	41a86fb2dd	Simplify static Showability of a PreferenceItem ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:25 +03:00
Janne Savolainen	1a5073caad	Remove duplication from exhaustiveness checks for discriminating unions ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:25 +03:00
Janne Savolainen	497ab273ae	Fix import path after rebase ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:25 +03:00
Janne Savolainen	027a52fd7e	Update snapshots after rebase ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:24 +03:00
Janne Savolainen	dadb53b3e0	Remove dead code ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:24 +03:00
Janne Savolainen	68e38dd0a3	Relocate code under a sub-feature ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:24 +03:00
Janne Savolainen	042ae56ae1	Move code under a feature ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:23 +03:00
Janne Savolainen	a7f300a010	Consolidate navigating to preferences ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:23 +03:00
Janne Savolainen	8dca046495	Move code under a feature ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:23 +03:00
Iku-turso	4fbc14225f	Update snapshot ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:23 +03:00
Iku-turso	f88de99511	Extract "composable-responsibilities" for Discriminable, Labelable, Orderable, and Showable ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:23 +03:00
Janne Savolainen	5503b938b7	Make HTML element discovery require less parameters ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:22 +03:00
Janne Savolainen	edb12fed06	Make winner of competition to use original route for preferences ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:22 +03:00
Janne Savolainen	36fda762d0	Move application update related preferences under application update feature ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:22 +03:00
Janne Savolainen	911191fee0	Consolidate sizing of horizontal line to t-shirts ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:22 +03:00
Janne Savolainen	8e8161e5fb	Move shared UI component to more common place ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:22 +03:00
Janne Savolainen	81c748b7e8	Rename a preference item type to better communicate intent in UI ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:21 +03:00
Janne Savolainen	95767e9d95	Move utility functions to common ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:21 +03:00
Janne Savolainen	f212c2a86d	Consolidate directory structure of composite ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:21 +03:00
Janne Savolainen	c96f562c69	Consolidate name of function ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:20 +03:00
Janne Savolainen	638ea2e12e	Clean public interface of a normalize composite ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:20 +03:00
Janne Savolainen	c04adf3eff	Make sense in horizontal lines ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:20 +03:00
Janne Savolainen	409e39deb8	Consolidate naming ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:20 +03:00
Janne Savolainen	629d86c5ff	Start considering application preferences as default tab ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:20 +03:00
Iku-turso	40a5732b26	Replace usages of react-component factory with actual components for simplicity ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:19 +03:00
Iku-turso	7c7307a8b5	Update snapshots ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:19 +03:00
Iku-turso	120c27a716	Remove "group" from preference types, as it is exact replica of "item" ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:19 +03:00
Iku-turso	ca3d3c7aed	Add todo ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:19 +03:00
Iku-turso	f7e250ea85	Make styling less brittle by not relying on static HTML-element structures with CSS-rules ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:19 +03:00
Janne Savolainen	329e251aa1	Update snapshots ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:19 +03:00
Janne Savolainen	ad1d9427fe	Implement registrator for preference items ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:18 +03:00
Janne Savolainen	14ab27288a	Fix import ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:18 +03:00
Janne Savolainen	aedcded822	Remove duplication from preference pages ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:17 +03:00
Janne Savolainen	9548bb71f9	Remove test ID made redundant by consolidating discovery of HTML elements ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:17 +03:00
Janne Savolainen	5554f895df	Consolidate discovery of HTML elements in a test ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:17 +03:00
Janne Savolainen	bdd901b3e0	Adapt test setup to changes in preference navigation ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:16 +03:00
Janne Savolainen	92a8678c30	Update snapshots ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:16 +03:00