3172 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Iku-turso	a03a0e9352	Rename type for accuracy ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 15:14:32 +03:00
Iku-turso	5b916be7c0	Start using named export for composite ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 15:06:23 +03:00
Iku-turso	e7b652c627	Consolidate logic for application menu for Windows to be based on composite ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:59:37 +03:00
Iku-turso	867be0562f	Make more showables maybe showable ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:42:20 +03:00
Iku-turso	95cba7a061	Extract being maybe Showable as explicit composable responsibility ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	fc2cf4f457	Simplify usages of Orderable and Showable ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	b4f48a30cc	Make non-shown application menu items not break composite structure ... This was made apparent by adding related unit tests for all known environments. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	7048683c14	Simplify "Showable" ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	2a2ab66a44	Consolidate tests to now point-free composite ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	e9d951920c	Simplify unit tests for composite ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	4eec9330eb	Kill dead code ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	2a678b44c9	Make composite unit test an unrealistic test scenario about undefined ids ... Also make the thrown error suggest how to fix the problem. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	271255114c	Remove some duplication from tests of composite ... Also make the thrown error suggest how to fix the problem. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	11d2023c70	Make composite not know about how children are transformed ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:39:32 +03:00
Iku-turso	c6782954b1	Make attempts to log error throw in unit tests ... Errors cannot be allowed to happen without a unit test explicitly causing it. Errors cannot be allowed to happen without author of unit test knowing it. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 14:37:10 +03:00
Iku-turso	890c5a5310	Make global overrides for functions log args of the call for devability ... Also make the thrown error suggest how to fix the problem. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 10:38:21 +03:00
Janne Savolainen	1eb45ac1a4	Consolidate output of get-composite-path to match find-composite's input ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-24 09:28:46 +03:00
Iku-turso	20aaaafce3	Adapt application builder and tests to array-like paths over string-like paths ... Array-like paths do not have weakness for special characters as part of id, such as ".". Also note: the error messaging for clicking of application menu in application builder is a bit worse now I think, but the simplification of the test code is worth it in this case IMHO. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 16:04:17 +03:00
Iku-turso	19e3dd77b4	Make composite not care about formatting of ids ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 16:04:17 +03:00
Iku-turso	4c31f4f6a7	Adapt application builder and tests to array-like paths over string-like paths ... Array-like paths do not have weakness for special characters as part of id, such as ".". Also note: the error messaging for clicking of application menu in application builder is a bit worse now I think, but the simplification of the test code is worth it in this case IMHO. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 15:20:01 +03:00
Iku-turso	5b9ce7bbb2	Make composite not care about in formatting of ids ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 14:24:45 +03:00
Janne Savolainen	f4fc38b161	Adapt more integration tests to recent changes ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 13:21:27 +03:00
Janne Savolainen	d743380012	Adapt integration test to recent changes ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 12:40:42 +03:00
Janne Savolainen	8f39e86b15	Fix lint error ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:26 +03:00
Janne Savolainen	70088bb4d1	Update snapshots ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:26 +03:00
Iku-turso	067ecd0eee	Remove additional separators when separated items are not shown for having no content ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:26 +03:00
Iku-turso	aa785c9738	Make separator in Map-component know left and right item ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:26 +03:00
Iku-turso	18f1e1b6aa	Extract responsibility of "separability" ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:26 +03:00
Iku-turso	f59f771947	Move general function to general directory ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:25 +03:00
Iku-turso	41a86fb2dd	Simplify static Showability of a PreferenceItem ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:25 +03:00
Iku-turso	b33a445f41	Update link to a more recent article ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:25 +03:00
Janne Savolainen	7702be95e6	Add TODO ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:25 +03:00
Janne Savolainen	1a5073caad	Remove duplication from exhaustiveness checks for discriminating unions ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:25 +03:00
Janne Savolainen	497ab273ae	Fix import path after rebase ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:25 +03:00
Janne Savolainen	027a52fd7e	Update snapshots after rebase ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:24 +03:00
Janne Savolainen	ea6d2a2365	Fix merge conflicts ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:24 +03:00
Janne Savolainen	dadb53b3e0	Remove dead code ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:24 +03:00
Janne Savolainen	0efe1c5ea0	Add TODO ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:24 +03:00
Janne Savolainen	68e38dd0a3	Relocate code under a sub-feature ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:24 +03:00
Janne Savolainen	042ae56ae1	Move code under a feature ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:23 +03:00
Janne Savolainen	a7f300a010	Consolidate navigating to preferences ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:23 +03:00
Janne Savolainen	8dca046495	Move code under a feature ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:23 +03:00
Janne Savolainen	e5c3132688	Remove dead code ... Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:23 +03:00
Iku-turso	4fbc14225f	Update snapshot ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:23 +03:00
Iku-turso	f88de99511	Extract "composable-responsibilities" for Discriminable, Labelable, Orderable, and Showable ... Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>	2022-10-21 08:23:23 +03:00
Janne Savolainen	5503b938b7	Make HTML element discovery require less parameters ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:22 +03:00
Janne Savolainen	edb12fed06	Make winner of competition to use original route for preferences ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:22 +03:00
Janne Savolainen	36fda762d0	Move application update related preferences under application update feature ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:22 +03:00
Janne Savolainen	911191fee0	Consolidate sizing of horizontal line to t-shirts ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:22 +03:00
Janne Savolainen	8e8161e5fb	Move shared UI component to more common place ... Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>	2022-10-21 08:23:22 +03:00