 Iku-turso
|
e3c54705ac
|
Improve variable name
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:32 +03:00 |
|
|
Iku-turso
|
acf04d2604
|
Fix bad merge
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:32 +03:00 |
|
|
Iku-turso
|
7b0ac796d2
|
Add a deprecation from a review comment
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:31 +03:00 |
|
|
Iku-turso
|
6ed5244421
|
Fix artifact from bad rebase
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:31 +03:00 |
|
|
Iku-turso
|
480bad870f
|
Fix code style
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:30 +03:00 |
|
|
Iku-turso
|
06b8384fa1
|
Adapt integration tests to recent changes
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:30 +03:00 |
|
|
Iku-turso
|
836c2c1dbf
|
Prevent unit tests from failing because of non-standard method of HTML-element not present in js-dom
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:30 +03:00 |
|
|
Iku-turso
|
9a5a210ed3
|
Migrate to actual typing for di.permitSideEffects
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:30 +03:00 |
|
|
Iku-turso
|
906f23214e
|
Prevent old unit test with side effects from accessing file system
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:30 +03:00 |
|
|
Iku-turso
|
03cd6aac87
|
Remove kludge in previous commit by explicitly permitting specific side effects where old unit tests require it
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:29 +03:00 |
|
|
Iku-turso
|
333ef65441
|
Temporarily kludge all unit tests green with a disclaimer about allowing side-effects
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:29 +03:00 |
|
|
Iku-turso
|
eb756f4da4
|
Make legacy unit tests for hotbar green and more simple by using the new legacy helper
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:29 +03:00 |
|
|
Iku-turso
|
b935dbca78
|
Introduce a legacy-helper to make gradual refactoring of inheritors of Singleton easier
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:29 +03:00 |
|
|
Iku-turso
|
d8fdd12a3c
|
Extract instantiation of "conf" as injectables for causing side effects
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:29 +03:00 |
|
|
Iku-turso
|
1bf61b6870
|
Prevent explicit side effect in component by using existing dependency instead
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:28 +03:00 |
|
|
Iku-turso
|
ec33125373
|
Specify id for all <Select /> to satisfy previous commit
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:28 +03:00 |
|
|
Iku-turso
|
9c024b98d3
|
Require id for <Select /> to prevent non-deterministic renders
This was caused by global state in a 3rd party lib: "react-select".
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:28 +03:00 |
|
|
Iku-turso
|
b947568b14
|
Make a directory commonly available
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-03-31 15:13:28 +03:00 |
|
|
Iku-turso
|
5e429d2b93
|
Yarn scripts for quality of life in development (#5087)
|
2022-03-28 09:09:30 -04:00 |
|
|
Iku-turso
|
ab4780f67c
|
Deprecate some undesirables (#5086)
|
2022-03-23 16:25:10 -04:00 |
|
|
Iku-turso
|
6b28f9e9c3
|
Bump injectable to 5.1.2 (#5010)
|
2022-03-17 08:15:21 -04:00 |
|
|
Iku-turso
|
0b321f7144
|
Merge pull request #4653 from lensapp/eliminate-gst-from-app-paths
Eliminate Global Shared State from app paths and relatives
|
2022-01-17 19:24:15 +02:00 |
|
 Iku-tursoandJanne Savolainen
|
d89609415b
|
Kludge a timing issue until root cause of shared global state is fixed
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-01-07 12:10:04 +02:00 |
|
|
Iku-tursoandJanne Savolainen
|
f089d5c9e6
|
Add missing todo
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
|
2022-01-07 12:10:04 +02:00 |
|
|
Iku-tursoandJanne Savolainen
|
f3d45ea78b
|
Fix hangup on application start by auto-registering more injectables
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-12-09 14:35:29 +02:00 |
|
|
Mikko AspialaandJanne Savolainen
|
2e5e549957
|
Update version of injectable for disambiguous typing
Signed-off-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
|
2021-11-26 07:44:27 +02:00 |
|