hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity
3,135 Commits 268 Branches 11 Tags
0efe1c5ea0aa188678331a376a00b07bc5e859bf
Commit Graph
3135 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Janne Savolainen 0efe1c5ea0 Add TODO 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:24 +03:00
Janne Savolainen 68e38dd0a3 Relocate code under a sub-feature 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:24 +03:00
Janne Savolainen 042ae56ae1 Move code under a feature 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:23 +03:00
Janne Savolainen a7f300a010 Consolidate navigating to preferences 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:23 +03:00
Janne Savolainen 8dca046495 Move code under a feature 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:23 +03:00
Janne Savolainen e5c3132688 Remove dead code 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:23 +03:00
Iku-tursoandJanne Savolainen 4fbc14225f Update snapshot 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:23 +03:00
Iku-tursoandJanne Savolainen f88de99511 Extract "composable-responsibilities" for Discriminable, Labelable, Orderable, and Showable 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:23 +03:00
Janne SavolainenandMikko Aspiala 5503b938b7 Make HTML element discovery require less parameters 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:22 +03:00
Janne SavolainenandMikko Aspiala edb12fed06 Make winner of competition to use original route for preferences 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:22 +03:00
Janne SavolainenandMikko Aspiala 36fda762d0 Move application update related preferences under application update feature 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:22 +03:00
Janne SavolainenandMikko Aspiala 911191fee0 Consolidate sizing of horizontal line to t-shirts 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:22 +03:00
Janne SavolainenandMikko Aspiala 8e8161e5fb Move shared UI component to more common place 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:22 +03:00
Janne SavolainenandMikko Aspiala 81c748b7e8 Rename a preference item type to better communicate intent in UI 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:21 +03:00
Janne SavolainenandMikko Aspiala 95767e9d95 Move utility functions to common 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:21 +03:00
Janne SavolainenandMikko Aspiala f212c2a86d Consolidate directory structure of composite 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:21 +03:00
Janne SavolainenandMikko Aspiala c96f562c69 Consolidate name of function 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:20 +03:00
Janne SavolainenandMikko Aspiala 638ea2e12e Clean public interface of a normalize composite 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:20 +03:00
Janne Savolainen c04adf3eff Make sense in horizontal lines 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:20 +03:00
Janne SavolainenandMikko Aspiala 409e39deb8 Consolidate naming 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:20 +03:00
Janne SavolainenandMikko Aspiala 629d86c5ff Start considering application preferences as default tab 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:20 +03:00
Iku-tursoandJanne Savolainen 40a5732b26 Replace usages of react-component factory with actual components for simplicity 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:19 +03:00
Iku-tursoandJanne Savolainen 7c7307a8b5 Update snapshots 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:19 +03:00
Iku-tursoandJanne Savolainen 120c27a716 Remove "group" from preference types, as it is exact replica of "item" 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:19 +03:00
Iku-tursoandJanne Savolainen ca3d3c7aed Add todo 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:19 +03:00
Iku-tursoandJanne Savolainen f7e250ea85 Make styling less brittle by not relying on static HTML-element structures with CSS-rules 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:19 +03:00
Janne SavolainenandMikko Aspiala 329e251aa1 Update snapshots 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:19 +03:00
Janne SavolainenandMikko Aspiala ad1d9427fe Implement registrator for preference items 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:18 +03:00
Iku-tursoandJanne Savolainen c581713ca1 Make element discovery able to discover without value for attribute 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:18 +03:00
Iku-tursoandJanne Savolainen 18a3325977 Make element discovery able to do nested discovery 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:18 +03:00
Iku-tursoandJanne Savolainen e93ac55d1d Make queries in element discovery return matching attribute values for easier testing 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:18 +03:00
Janne Savolainen 14ab27288a Fix import 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:18 +03:00
Janne Savolainen aedcded822 Remove duplication from preference pages 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:17 +03:00
Janne SavolainenandMikko Aspiala 9548bb71f9 Remove test ID made redundant by consolidating discovery of HTML elements 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:17 +03:00
Janne SavolainenandMikko Aspiala 5554f895df Consolidate discovery of HTML elements in a test 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:17 +03:00
Janne SavolainenandMikko Aspiala bb65dc93b2 Remove uninteresting technical tests that are covered by behavioural ones 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:17 +03:00
Janne SavolainenandMikko Aspiala bdd901b3e0 Adapt test setup to changes in preference navigation 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:16 +03:00
Janne SavolainenandMikko Aspiala 852dee6c04 Adapt application builder to changes in preference navigation 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:16 +03:00
Janne SavolainenandMikko Aspiala 92a8678c30 Update snapshots 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:16 +03:00
Janne SavolainenandMikko Aspiala 4249ae1f7d Consolidate discovery of HTML elements in some tests 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:16 +03:00
Janne SavolainenandMikko Aspiala beb0103427 Kill dead code 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:16 +03:00
Janne SavolainenandMikko Aspiala 66dd1ab65e Introduce test helper to abstract discovery of HTML elements 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:15 +03:00
Janne SavolainenandMikko Aspiala cbfae0b6f5 Tweak UI for preference navigation tab groups 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:15 +03:00
Iku-tursoandJanne Savolainen 6f4a6c95fc Remove code made redundant with hiding of preference tabs without content 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:15 +03:00
Iku-tursoandJanne Savolainen ca5e5034e6 Make tab groups and tabs in preferences not render when there is no content 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:15 +03:00
Iku-tursoandJanne Savolainen f48dcba59d Introduce way to find out if composite has a descendant 
This will serve eg. hiding of empty preference tab groups.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:15 +03:00
Janne Savolainen dd0e2dc394 Add extensions tab group to preferences 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:15 +03:00
Janne Savolainen fe8bd649c8 Remove dead code 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:14 +03:00
Janne Savolainen ed14cdc204 Remove usage of old code 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:14 +03:00
Janne Savolainen c7ce675a02 Move code under a Feature 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:14 +03:00